refactor: extract business logic from listeners into services#16
Merged
Conversation
Move business logic from EventListeners into dedicated Service classes:
- IngestService (from IngestFromUpstream)
- RecordService (from ConvertDepositionToRecord)
- IndexService (from ProjectNewRecordToIndexes)
Listeners now delegate to services, enabling unit testing without
event infrastructure and reuse from multiple entry points.
Closes #14
|
Contributor
Author
|
Closes #17 |
Add comprehensive CI pipeline with lint, typecheck, and test jobs using uv for dependency management and pytest for testing with coverage reporting on pull requests Closes #17
fix: replace pyright with ty for type checking in lint command
chore: add pre-commit configuration with ruff, type checking, and tests
4c7d97f to
667edb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
IngestFromUpstreamIngestServiceConvertDepositionToRecordRecordServiceProjectNewRecordToIndexesIndexServiceTest plan
Closes #14