refactor: rename ingestor to source throughout codebase#24
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
This pull request performs a comprehensive refactoring to rename "ingestor" terminology to "source" throughout the entire codebase. This change better reflects the broader purpose of these components, which can handle data from multiple source types including pull APIs, user uploads, and webhooks.
Changes:
- Renamed all directories from
ingest/andingestors/tosource/andsources/ - Updated all classes, events, and services to use "Source" terminology
- Updated configuration models and entry points to reflect the new naming convention
Reviewed changes
Copilot reviewed 53 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/domain/source/test_source_service.py | Updated unit tests to use new SourceService naming and test methods |
| tests/test_sources/geo_entrez/test_source.py | Updated integration tests to use GEOEntrezSource instead of GEOEntrezIngestor |
| sources/geo_entrez/source.py | Renamed GEOEntrezIngestor class to GEOEntrezSource |
| sources/geo_entrez/config.py | Updated config to inherit from SourceConfig |
| sources/geo_entrez/init.py | Updated exports to use new Source naming |
| sources/init.py | New sources package initialization with updated documentation |
| pyproject.toml | Updated entry points from "osa.ingestors" to "osa.sources" |
| osa/sdk/source/source.py | Renamed Ingestor protocol to Source protocol |
| osa/sdk/source/record.py | New file location for UpstreamRecord (formerly in ingest) |
| osa/sdk/source/config.py | Renamed IngestorConfig to SourceConfig |
| osa/sdk/source/init.py | Updated SDK exports for source components |
| osa/sdk/ingest/* | Removed old ingest SDK files |
| osa/infrastructure/source/discovery.py | Renamed discovery functions and classes from Ingestor to Source |
| osa/infrastructure/source/di.py | Updated DI provider to use SourceRegistry and SourceService |
| osa/infrastructure/ingest/* | Removed old ingest infrastructure files |
| osa/infrastructure/event/di.py | Updated event listeners and schedules to use new Source naming |
| osa/domain/source/service/source.py | Renamed IngestService to SourceService with updated method names |
| osa/domain/source/schedule/source_schedule.py | Renamed IngestSchedule to SourceSchedule |
| osa/domain/source/model/registry.py | Renamed IngestorRegistry to SourceRegistry |
| osa/domain/source/listener/* | Renamed event listeners from IngestFromUpstream to PullFromSource |
| osa/domain/source/event/* | Renamed events from IngestRequested to SourceRequested |
| osa/domain/ingest/* | Removed old ingest domain files |
| osa/domain/shared/event.py | Updated docstring examples to use Source terminology |
| osa/domain/deposition/model/aggregate.py | Updated comment from "Ingestor info" to "Source info" |
| osa/domain/deposition/command/submit.py | Updated comment from "not from ingest" to "not from source" |
| osa/config.py | Renamed IngestConfig to SourceConfig and updated all related fields |
| osa/cli/commands/local.py | Updated config templates to use sources instead of ingestors |
| osa/application/di.py | Updated DI container to use SourceProvider |
| osa/application/api/rest/app.py | Updated startup validation to use validate_sources_at_startup |
| ingestors/* | Removed old ingestors directory files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ingestorterminology tosourceacross the entire codebaseChanges
osa/domain/ingest/→source/,osa/infrastructure/ingest/→source/,osa/sdk/ingest/→source/,ingestors/→sources/Ingestor→Source,IngestorRegistry→SourceRegistry,IngestService→SourceServiceIngestConfig→SourceConfig, fieldingestors→sourcesIngestRequested→SourceRequested,PullFromSource,TriggerInitialSourceRunosa.ingestors→osa.sourcesCloses #21