Do in-source build on EL9 #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the build not finding the Makefile on EL9. See https://opensciencegrid.atlassian.net/browse/SOFTWARE-5510?focusedCommentId=376297 for explanation
djw8605
approved these changes
Mar 18, 2023
Member
djw8605
left a comment
djw8605
left a comment
There was a problem hiding this comment.
LGTM
I presume we should move to the cmake macros later.
Contributor
Author
|
I didn't see the cmake macros on el7 so we'll have to conditionally define them ourselves if we want to use them. Or wait until el7 is EOL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build not finding the Makefile on EL9. See https://opensciencegrid.atlassian.net/browse/SOFTWARE-5510?focusedCommentId=376297 for explanation