Skip to content

Enable ZIP_DEFLATED compression for office files#74

Merged
AHReccese merged 4 commits intoopenscilab:devfrom
phreaker0:patch-1
Apr 15, 2026
Merged

Enable ZIP_DEFLATED compression for office files#74
AHReccese merged 4 commits intoopenscilab:devfrom
phreaker0:patch-1

Conversation

@phreaker0
Copy link
Copy Markdown

Reference Issues/PRs

n/a

What does this implement/fix? Explain your changes.

docx/xlsx/pptx by default use the DEFLATE compression. After removing the metadata dmeta saves the output as a zip file without any compression applied resulting in a bigger file than before (in my case a ~100 kb file increased to ~500kb after using dmeta).

So let dmeta also use the DEFLATE compression for saving.

Any other comments?

docx/xlsx/pptx by default use the DEFLATE compression. After removing the metadata dmeta saves the output as a zip file without any compression applied resulting in a bigger file than before (in my case a ~100 kb file increased to ~500kb after using dmeta).

So let dmeta also use the DEFLATE compression for saving.
@AHReccese AHReccese self-requested a review April 13, 2026 05:21
@AHReccese AHReccese added this to the DMeta v0.5 milestone Apr 13, 2026
@AHReccese AHReccese added the enhancement New feature or request label Apr 13, 2026
Copy link
Copy Markdown
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Thank you for the PR, good point!

Please add the following to CHANGELOG.md under ## [Unreleased] in the ### Changed subsection:

  • clear function in functions.py
  • update function in functions.py

@phreaker0 phreaker0 requested review from AHReccese April 13, 2026 09:02
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 13, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Copy link
Copy Markdown
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request need to be from your fork into dev branch not main. Please reflect this.
@phreaker0

Copy link
Copy Markdown
Member

@AHReccese AHReccese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your pull request need to be from your fork into dev branch not main. Please reflect this and we will be ready to merge this PR.
@phreaker0

@phreaker0 phreaker0 changed the base branch from main to dev April 15, 2026 07:11
@phreaker0 phreaker0 requested a review from AHReccese April 15, 2026 07:12
@AHReccese
Copy link
Copy Markdown
Member

@phreaker0 LGTM! Thanks.

@AHReccese AHReccese merged commit 24a2683 into openscilab:dev Apr 15, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants