Skip to content

Conversation

@AHReccese
Copy link
Member

Reference Issues/PRs

#93

What does this implement/fix? Explain your changes.

Any other comments?

@AHReccese AHReccese self-assigned this Dec 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.42%. Comparing base (d1fd333) to head (3b6d108).

Files with missing lines Patch % Lines
ipspot/ipv4.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #99      +/-   ##
==========================================
+ Coverage   70.96%   71.42%   +0.46%     
==========================================
  Files           4        4              
  Lines         465      476      +11     
  Branches       47       48       +1     
==========================================
+ Hits          330      340      +10     
  Misses        117      117              
- Partials       18       19       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AHReccese AHReccese marked this pull request as ready for review December 18, 2025 03:48
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHReccese
Thank you for your efforts. Please update the test_ipv4_functions.py file for this new API (network and timeout error cases)

@sepandhaghighi sepandhaghighi added this to the ipspot v0.8 milestone Dec 20, 2025
Copy link
Member

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@sepandhaghighi sepandhaghighi merged commit 76a1e79 into dev Dec 20, 2025
48 of 49 checks passed
@sepandhaghighi sepandhaghighi deleted the new_api_dpip branch December 20, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants