Enhancement/custom share #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepandhaghighi
requested changes
Feb 1, 2025
Member
sepandhaghighi
left a comment
sepandhaghighi
left a comment
There was a problem hiding this comment.
@F-Shahali Thank you for your efforts. Well done! 🔥
I have one comment:
- Please remove
Custom Sharefromdirectmode.
AHReccese
approved these changes
Feb 1, 2025
Member
AHReccese
left a comment
AHReccese
left a comment
There was a problem hiding this comment.
Thank you for your Efforts. Works as expected!
CHANGELOG.md
Outdated
| - `Custom Share` button | ||
| - Add `ServiceName` enum | ||
| ### Changed | ||
| - Remove `Custom Share` from `direct` mode |
Member
There was a problem hiding this comment.
Since Custom Share feature is just added in this PR, you don't need to write newly applied changes in this PR in the CHANGELOG.md.
Collaborator
Author
There was a problem hiding this comment.
You are right, thanks.
F-Shahali
force-pushed
the
enhancement/custom-share
branch
from
7b70191 to
c5525fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#47
What does this implement/fix? Explain your changes.
Any other comments?