Skip to content

feat: Add support for using pathlib.Path filenames#238

Merged
lewisjared merged 5 commits intomasterfrom
196-pathlib-support
May 17, 2023
Merged

feat: Add support for using pathlib.Path filenames#238
lewisjared merged 5 commits intomasterfrom
196-pathlib-support

Conversation

@lewisjared
Copy link
Copy Markdown
Collaborator

@lewisjared lewisjared commented May 16, 2023

Supported for reading and writing from CSV and netCDF

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2023

Codecov Report

Patch coverage: 95.83% and project coverage change: -0.03 ⚠️

Comparison is base (753e83f) 95.77% compared to head (d22f4cb) 95.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   95.77%   95.74%   -0.03%     
==========================================
  Files          23       24       +1     
  Lines        2108     2117       +9     
  Branches      395      391       -4     
==========================================
+ Hits         2019     2027       +8     
- Misses         71       72       +1     
  Partials       18       18              
Impacted Files Coverage Δ
src/scmdata/netcdf.py 98.11% <87.50%> (-1.89%) ⬇️
src/scmdata/_typing.py 100.00% <100.00%> (ø)
src/scmdata/run.py 96.14% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lewisjared lewisjared requested a review from znicholls May 16, 2023 23:12
Copy link
Copy Markdown
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple of things to try re type hints, might be a deep rabbit hole though so let's just make issues if we want to guarantee that this won't become a massive time sink

Copy link
Copy Markdown
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, couple of things to try re type hints, might be a deep rabbit hole though so let's just make issues if we want to guarantee that this won't become a massive time sink

@lewisjared lewisjared merged commit 72d4f4d into master May 17, 2023
@lewisjared lewisjared deleted the 196-pathlib-support branch May 17, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants