-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Explore] remove data-explorer and introduce sample route for flavors #9835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
…gistration in observability workspaces Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9835 +/- ##
=======================================
Coverage 61.73% 61.73%
=======================================
Files 3991 3988 -3
Lines 95339 95317 -22
Branches 15408 15407 -1
=======================================
- Hits 58858 58848 -10
+ Misses 32602 32584 -18
- Partials 3879 3885 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
030ba2d to
cddea1a
Compare
Signed-off-by: Joshua Li <joshuali925@gmail.com>
9581bdd to
1310bdb
Compare
Signed-off-by: Joshua Li <joshuali925@gmail.com>
1310bdb to
9c56960
Compare
Signed-off-by: Joshua Li <joshuali925@gmail.com>
|
closing, #9902 will take over |
Description
This PR removes view service and data-explorer in explore plugin to flatten the structure. It removes registration and management of multiple slices in data-explorer and only uses a single slice, but does not modify the structure. @ananzh I think we'd need to sync up on the state management refactor part.
To introduce a new flavor, the
application.tsxcomponent should properly route it to the right page. Example:If user goes to
app/exploreorapp/explore/logs#/, Explore shows the logs flavor. If they go toapp/explore/traces#/, it shows the traces flavor. The left nav bar will only show the "Discover" item. Redirection from saved explore is not implemented as they do not store flavor yet.This PR is built on top of #9813.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration