Remove max_primary_shard_size from rollover examples
#9805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of supported conditions is correct, but the examples use `max_primary_shard_size` which is not supported. This change uses `max_size` in the examples instead. There was also a formatting error on a table. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
requested review from
AMoo-Miki,
Naarcha-AWS,
dlvenable,
epugh,
kolchfa-aws and
natebower
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
approved these changes
May 1, 2025
Collaborator
kolchfa-aws
left a comment
kolchfa-aws
left a comment
There was a problem hiding this comment.
Thank you, @andrross! LGTM
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 1, 2025
The list of supported conditions is correct, but the examples use `max_primary_shard_size` which is not supported. This change uses `max_size` in the examples instead. There was also a formatting error on a table. Signed-off-by: Andrew Ross <andrross@amazon.com> (cherry picked from commit 2082dae) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zane-neo
pushed a commit
to zane-neo/documentation-website
that referenced
this pull request
May 2, 2025
…oject#9805) The list of supported conditions is correct, but the examples use `max_primary_shard_size` which is not supported. This change uses `max_size` in the examples instead. There was also a formatting error on a table. Signed-off-by: Andrew Ross <andrross@amazon.com>
KishoreKicha14
pushed a commit
to KishoreKicha14/documentation-website
that referenced
this pull request
Jun 13, 2025
…oject#9805) The list of supported conditions is correct, but the examples use `max_primary_shard_size` which is not supported. This change uses `max_size` in the examples instead. There was also a formatting error on a table. Signed-off-by: Andrew Ross <andrross@amazon.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Jul 2, 2025
…oject#9805) The list of supported conditions is correct, but the examples use `max_primary_shard_size` which is not supported. This change uses `max_size` in the examples instead. There was also a formatting error on a table. Signed-off-by: Andrew Ross <andrross@amazon.com> Signed-off-by: Eric Pugh <epugh@opensourceconnections.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of supported conditions is correct, but the examples use
max_primary_shard_sizewhich is not supported. This change usesmax_sizein the examples instead.Related to opensearch-project/OpenSearch#18174
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.