fix bug handleReprovision missing wait_for_completion_timeout response

[junweid62]

Description

bug fix

Related Issues

Resolves #1106

Check List

• New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[dbwiddis]

Should this have been caught in an integ test?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.33%. Comparing base (f8923ab) to head (e23003a).
Report is 4 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #1107      +/-   ##
============================================
+ Coverage     77.30%   77.33%   +0.03%     
- Complexity     1094     1096       +2     
============================================
  Files           101      101              
  Lines          5305     5308       +3     
  Branches        510      511       +1     
============================================
+ Hits           4101     4105       +4     
  Misses          954      954              
+ Partials        250      249       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[junweid62]

Should this have been caught in an integ test?

I’ve already added a unit test for this case, but it looks like we don’t currently have an integration test that would have caught it. Might be worth considering adding one.

[dbwiddis]

Unit test is probably enough here.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-1107-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f7d5501495d1852e32b0b25356229ab0d135713
# Push it to GitHub
git push --set-upstream origin backport/backport-1107-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1107-to-2.x.

[opensearch-trigger-bot]

The backport to 2.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.19 2.19
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.19
# Create a new branch
git switch --create backport/backport-1107-to-2.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f7d5501495d1852e32b0b25356229ab0d135713
# Push it to GitHub
git push --set-upstream origin backport/backport-1107-to-2.19
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.19

Then, create a pull request where the base branch is 2.19 and the compare/head branch is backport/backport-1107-to-2.19.