Force tests jackson dependencies to 2.18#911
Merged
dbwiddis merged 2 commits intoopensearch-project:mainfrom Oct 10, 2024
Merged
Force tests jackson dependencies to 2.18#911dbwiddis merged 2 commits intoopensearch-project:mainfrom
dbwiddis merged 2 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Owais <owaiskazi19@gmail.com>
owaiskazi19
requested review from
amitgalitz,
dbwiddis,
jackiehanyang,
joshpalis and
ohltyler
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
=========================================
Coverage 78.07% 78.07%
Complexity 995 995
=========================================
Files 99 99
Lines 4621 4621
Branches 431 431
=========================================
Hits 3608 3608
Misses 833 833
Partials 180 180 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Oct 10, 2024
Signed-off-by: Owais <owaiskazi19@gmail.com>
owaiskazi19
force-pushed
the
force-jackson
branch
from
3e11199 to
3e1b0a3
Compare
junweid62
approved these changes
Oct 10, 2024
joshpalis
approved these changes
Oct 10, 2024
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-911-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 30966d6be53a99e7af880d7a11603d57cdc98da7
# Push it to GitHub
git push --set-upstream origin backport/backport-911-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.xThen, create a pull request where the |
Member
|
@owaiskazi19 @junweid62 one of you should do this backport :) |
Collaborator
|
Hey @owaiskazi19, could you help out with this backport? I’m currently tied up with bug fixing over on the Trineo side and might not have the time to dive deep into this right now. Thanks a lot in advance! |
5 tasks
Member
Author
|
Was already on it :) Here you go #912 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Coming from comment. Forced tests jackson dependencies to 2.18
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.