add sample templates for text to visualziation#936
Conversation
|
@dbwiddis @owaiskazi19 Could you take a look the PR please? |
|
@ruanyl Will do. I saw it earlier but it was in draft until just now. Note the spotless check is failing (looks like trailing whitespace). Please run |
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
4649941 to
ba05e6a
Compare
|
@ruanyl can you also some description about the use case for this template in the PR? |
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
============================================
- Coverage 78.07% 77.57% -0.50%
+ Complexity 996 993 -3
============================================
Files 99 99
Lines 4625 4714 +89
Branches 431 431
============================================
+ Hits 3611 3657 +46
- Misses 834 877 +43
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Description updated. Can u review again? |
|
@ruanyl Is there going to be a PR adding |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-936-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e259c12ebf40dcf8677343a1744643804f9efd02
# Push it to GitHub
git push --set-upstream origin backport/backport-936-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.xThen, create a pull request where the |
|
Probably a changelog conflict with #968. Will wait until that's merged and toggle the backport label |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/flow-framework/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/flow-framework/backport-2.x
# Create a new branch
git switch --create backport/backport-936-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e259c12ebf40dcf8677343a1744643804f9efd02
# Push it to GitHub
git push --set-upstream origin backport/backport-936-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/flow-framework/backport-2.xThen, create a pull request where the |
* add sample templates for text to visualziation Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * update text to visualziation prompt Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Update CHANGELOG Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * trailing whitespace Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
* add sample templates for text to visualziation Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * update text to visualziation prompt Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Update CHANGELOG Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * trailing whitespace Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Description
Add sample templates for text to visualization.
These templates will be used by OpenSearch-Dashboards plugin dashboards-assistant to setup text to visualization feature. Documentation could be found here: https://opensearch.org/docs/latest/dashboards/dashboards-assistant/text-to-visualization/
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.