Skip to content

Conversation

@deepdatta
Copy link
Contributor

Signed-off-by: Deep Datta deedatta@amazon.com

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has documentation added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Deep Datta <deedatta@amazon.com>
@deepdatta deepdatta requested a review from a team as a code owner August 12, 2022 03:23
Copy link
Member

@dlvenable dlvenable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to create a backport instead, but the infrastructure for it isn't working. This manual merge PR should be good for now.

I created #159 to support backports.

@@ -0,0 +1,26 @@
## Version 1.3.0 Release Notes
Copy link
Contributor

@sshivanii sshivanii Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the release note auto-generated, looks like it's not. Minor: We may want to get rid of sections Features and Documentation in that case since they're empty.

Copy link
Contributor

@sshivanii sshivanii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can clean it up later, this PR is good to go

@deepdatta
Copy link
Contributor Author

I tried to create a backport instead, but the infrastructure for it isn't working. This manual merge PR should be good for now.

I created #159 to support backports.

Thanks David

@deepdatta deepdatta merged commit f7f1f3f into 1.3 Aug 12, 2022
@sshivanii
Copy link
Contributor

sshivanii commented Aug 12, 2022

Looks like DCO is failing even though you have signed the commit. You may want to verify the correct email is setup in your git config:

git config --global user.email "correct_email@example.com"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants