Add lambda support by rupal-bq · Pull Request #14 · opensearch-project/reporting-cli

rupal-bq · 2023-01-31T21:27:48Z

Description

converted es6 modules to commonJS
Added Dockerfile to create container image for lambda
downgraded ora to resolve errors

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Dockerfile

joshuali925

some comments, didn't finish reviewing

.gitignore

Dockerfile

DEVELOPER_GUIDE.md

Dockerfile

package.json

src/arguments.js

vamsimanohar · 2023-02-01T18:06:10Z

Dockerfile

+WORKDIR ${FUNCTION_DIR}
+# Copy in the build image dependencies
+COPY --from=build-image ${FUNCTION_DIR} ${FUNCTION_DIR}
+RUN ls ${FUNCTION_DIR}/


Is this ls required?

Not required but helps to see if required files are present before deploying the image (added bcoz it helped me to debug, we can totally remove all ls commands)

Because it increases the image size and what is the final image size?

might be better to remove, i think it adds an unnecessary layer to image

removed. I am bit confused about size. On my local it shows 1.16GB but on ECR it shows 357.10MB.

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Dockerfile

joshuali925 · 2023-02-01T17:26:57Z

DEVELOPER_GUIDE.md

+1. Download the opensearch-reporting-cli-1.0.0.tgz file and get [Dockerfile](./Dockerfile).
+2. Run the command in from the directory where Dockerfile and opensearch-reporting-cli-1.0.0.tgz exists.
+    ```
+    docker build -t opensearch-reporting-cli .


users might be running this directly after cloning this repo and run npm install, do we need to dockerignore node_modules?

or do we expect users create a new directory, download Dockerfile and .tgz separately, and run docker build?

Also does this line work in mac/windows?

users might be running this directly after cloning this repo and run npm install, do we need to dockerignore node_modules?

Dockerfile is using opensearch-reporting-cli-1.0.0.tgz. If someone just clone repo & do npm install then docker build will throw error for not finding this tar file. We need to add dockerignore if we build from source.

do we expect users create a new directory, download Dockerfile and .tgz separately, and run docker build?

When we have this file on opensearch downloads page, we can add step to download tar file in Dockerfile so all user will need is to get Dockerfile and run build command. No need to clone the repo.

does this line work in mac/windows?

yes

Dockerfile

.gitignore

DEVELOPER_GUIDE.md

joshuali925 · 2023-02-01T19:04:55Z

also a note we might be able to use babel or babel+webpack to keep ES6 modules in src, babel will build CommonJS for lambda runtime. maybe a todo item in the future to improve code

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

joshuali925

minor comments

docs/examples/lambda_container_image.md

docs/examples/lambda_container_image_from_source.md

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>

rupal-bq added 16 commits January 24, 2023 17:22

Integrated new email template in cli

0086bcf

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Update help test

14a0dbb

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Delete temp img in for error case

cfc7aff

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

use const for emailTemplateImageBuffer

991ae6f

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

embed opensearch logo

6594bb5

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Accept text file for email body and add logic to convert text to html

0695340

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Increase wait time after dom modification

546cffd

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Add dockerfile

114e9e5

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Updates required for working with lambda

d523ef4

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Merge branch 'main' into docker-image

e794048

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Change path to fix test failure

ade0f50

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Add ora spinner back

e4c0394

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

nit

87d6b53

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Add promise for sending email, Update Dockerfile with tgz install

5fb125c

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

nit: log

f591d34

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Update doc

1df443c

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

rupal-bq marked this pull request as ready for review February 1, 2023 16:50

rupal-bq requested a review from a team as a code owner February 1, 2023 16:50

rupal-bq commented Feb 1, 2023

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

joshuali925 reviewed Feb 1, 2023

View reviewed changes

vamsimanohar reviewed Feb 1, 2023

View reviewed changes

Address PR comments

3435a6b

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

joshuali925 reviewed Feb 1, 2023

View reviewed changes

rupal-bq added 2 commits February 1, 2023 20:15

Update Dockerfile

ba961d0

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

nit: remove ls

7e211ad

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

rupal-bq mentioned this pull request Feb 1, 2023

use babel or babel+webpack to keep ES6 modules in src #16

Open

rupal-bq added 3 commits February 1, 2023 22:26

Move Dockerfile to example doc

6fa7429

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Add Dockerfile for building from source

4ce55be

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Nit: remove ls from Dockerfile

df689dd

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Adding apt-get remove -y google-chrome-stable

14609f7

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

joshuali925 reviewed Feb 1, 2023

View reviewed changes

rupal-bq and others added 4 commits February 2, 2023 00:02

Merge branch 'main' into docker-image

e172c7a

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Update example docs

dcd6b40

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

nit

94687e2

Signed-off-by: Rupal Mahajan <maharup@amazon.com>

Update docs/examples/lambda_container_image.md

be08114

Co-authored-by: Joshua Li <joshuali925@gmail.com>

joshuali925 approved these changes Feb 2, 2023

View reviewed changes

rupal-bq merged commit d98381d into opensearch-project:main Feb 2, 2023

alicejw1 mentioned this pull request Feb 2, 2023

[DOC] Reporting Anywhere CLI opensearch-project/documentation-website#836

Closed

Conversation

rupal-bq commented Jan 31, 2023

Description

Issues Resolved

Uh oh!

Uh oh!

joshuali925 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vamsimanohar Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

rupal-bq Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

vamsimanohar Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

joshuali925 Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

rupal-bq Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joshuali925 Feb 1, 2023

Choose a reason for hiding this comment

Uh oh!

rupal-bq Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

joshuali925 commented Feb 1, 2023

Uh oh!

joshuali925 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

rupal-bq Feb 1, 2023 •

edited

Loading