Skip to content

Conversation

@peternied
Copy link
Member

Description

Updating practices for maintainers

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <petern@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #1611 (6f68b95) into main (b34f762) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1611      +/-   ##
============================================
- Coverage     64.67%   64.58%   -0.10%     
+ Complexity     3220     3215       -5     
============================================
  Files           247      247              
  Lines         17351    17351              
  Branches       3082     3082              
============================================
- Hits          11222    11206      -16     
- Misses         4582     4596      +14     
- Partials       1547     1549       +2     
Impacted Files Coverage Δ
...t/keybyoidc/AuthenticatorUnavailableException.java 0.00% <0.00%> (-20.00%) ⬇️
...urity/ssl/transport/SecuritySSLNettyTransport.java 69.14% <0.00%> (-4.26%) ⬇️
.../auth/http/jwt/keybyoidc/SelfRefreshingKeySet.java 59.85% <0.00%> (-3.53%) ⬇️
...ic/auth/http/jwt/AbstractHTTPJwtAuthenticator.java 55.81% <0.00%> (-3.49%) ⬇️
...earch/security/ssl/util/SSLConnectionTestUtil.java 93.18% <0.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34f762...6f68b95. Read the comment docs.

@DarshitChanpura DarshitChanpura merged commit dc99569 into opensearch-project:main Feb 15, 2022
@peternied
Copy link
Member Author

@cliu123 Is this OK? We didn't have consensus before this change was merged

@peternied peternied deleted the maintainers-practice branch April 21, 2022 19:43
wuychn pushed a commit to ochprince/security that referenced this pull request Mar 16, 2023
Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants