Add jacoco report and pass the location to codecov #1617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
force-pushed
the
code-coverage
branch
from
d9a9b2f to
2a2afc9
Compare
davidlago
approved these changes
Feb 15, 2022
Member
Author
|
So CodeCov got the report - https://codecov.io/gh/opensearch-project/security/commit/2a2afc9062697937068634663c6d939e824bc8ef/build but it isn't updating this PR |
Member
Author
|
I'm seeing I think we need to merge at least once to get the coverage data all in... :/ I did generate a report so that is better than we saw before. I am going to wait on the merging of #1616, and retrigger the checks if they don't trigger automatically |
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…t#1617) * Add jacoco report and pass the location to codecov Signed-off-by: Peter Nied <petern@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add jacoco report and pass the location to codecov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.