Fix default precision and maxSize for all datetime types.#39
Merged
YANG-DB merged 1 commit intoopensearch-project:mainfrom Jan 5, 2023
Merged
Conversation
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
MaxKsyunz
approved these changes
Dec 19, 2022
YANG-DB
approved these changes
Jan 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 6e963e0)
YANG-DB
pushed a commit
that referenced
this pull request
Jan 5, 2023
) Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 6e963e0) Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yury-Fridlyand yury.fridlyand@improving.com
Description
The proposed fix changes default
PrecisionandDisplaySizeconfigured forTIMEandDATEtypes.https://github.com/Bit-Quill/opensearch-project-sql/blob/522901d0ce18ff36c54eb1acf10e3d2a0b9381e4/sql-jdbc/src/main/java/org/opensearch/jdbc/types/OpenSearchType.java#L146-L147
Precisionis the third arg andDisplaySizeis the fourth arg.https://github.com/Bit-Quill/opensearch-project-sql/blob/522901d0ce18ff36c54eb1acf10e3d2a0b9381e4/sql-jdbc/src/main/java/org/opensearch/jdbc/types/OpenSearchType.java#L65-L66
Please, note, classes referenced here
^arejava.sql.*classes, notjava.time.*ones.Timehas no fraction seconds part.See team review and discussion in Bit-Quill/opensearch-project-sql#185 and Bit-Quill/opensearch-project-sql#178
Test
Before
After
Issues Resolved
Fixes #21 and #19
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.