Fix antlr4 parser issues#3492
Merged
Merged
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
requested review from
GumpacG,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
Member
Author
6 tasks
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Member
Author
|
CI failure related to opensearch-project/job-scheduler#757 |
dai-chen
approved these changes
Apr 2, 2025
penghuo
approved these changes
Apr 2, 2025
penghuo
reviewed
Apr 2, 2025
Comment on lines
-1051
to
-1054
| | EARLIEST | ||
| | EARLIEST_TIME | ||
| | LATEST | ||
| | LATEST_TIME |
Member
Author
There was a problem hiding this comment.
Those keywords are not present in lexer.g4, another words, they are invalid here.
noCharger
reviewed
Apr 5, 2025
Comment on lines
+998
to
+1000
| | VARIABLE_COUNT_THRESHOLD | ||
| | FREQUENCY_THRESHOLD_PERCENTAGE | ||
| | WITH |
Collaborator
There was a problem hiding this comment.
Just confirming, do we need these in https://github.com/opensearch-project/opensearch-spark/blob/main/ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4 as well?
Member
Author
There was a problem hiding this comment.
Just confirming, do we need these in https://github.com/opensearch-project/opensearch-spark/blob/main/ppl-spark-integration/src/main/antlr4/OpenSearchPPLParser.g4 as well?
No for first two. WITH has already be presented in ppl-spark.
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
* Fix antlr4 parser issues Signed-off-by: Lantao Jin <ltjin@amazon.com> * Case insensitive lexer Signed-off-by: Lantao Jin <ltjin@amazon.com> --------- Signed-off-by: Lantao Jin <ltjin@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Resolves #3491
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.