use correct timezone name#3517
Merged
Merged
Conversation
Signed-off-by: xinyual <xinyual@amazon.com>
xinyual
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Swiddis
approved these changes
Apr 5, 2025
Collaborator
Swiddis
left a comment
Swiddis
left a comment
There was a problem hiding this comment.
Nice! Is the reason for the breakage that, depending on the actual timezone string, it may or may not be convertible back into a zone? So then it was failing tests based on where the GHA runner was
LantaoJin
approved these changes
Apr 6, 2025
6 tasks
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, we use getID() and it will return some three-letter time zone IDs like "PLT" which is already deprecated (see here). But toZoneId().toString() will return the full name like 'Asia/Karachi'.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#3516
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.