Fix GET_FORMAT UDF#3543
Merged
Merged
Conversation
by adding Locale.ROOT when converting string to lowercase to avoid irregular casting of I when defaulting to Turkic languages Signed-off-by: Yuanchun Shen <yuanchu@amazon.com>
yuancu
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
LantaoJin
approved these changes
Apr 14, 2025
qianheng-aws
approved these changes
Apr 14, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
by adding Locale.ROOT when converting string to lowercase to avoid irregular casting of I when defaulting to Turkic languages Signed-off-by: Yuanchun Shen <yuanchu@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
When locale is set using
-Dtests.locale=az-Cyrl,GET_FORMAT(TIME, [whatever])andGET_FORMAT(TIMESTAMP, [whatever])will always returnNULL.Root Cause
At
DateTimeFunctions.java:L1511, when the local is set to Turkic languages (e.g. Turkish, Azerbaijani),type.stringValue().toLowerCasewill returntımeforTIME, where ı is a dotless i, causing the key not existing in the predefined formats map.Fix
Specify locale as
Locale.ROOTwhen converting this string to lowercase.Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.