[Calcite Engine] Only enable fallback for tests that need to fall back#3544
Merged
Conversation
qianheng-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
seankao-az and
ykmr1224
as code owners
Signed-off-by: Heng Qian <qianheng@amazon.com>
qianheng-aws
force-pushed
the
ITRefactoring
branch
from
3252aaa to
568bc22
Compare
dai-chen
reviewed
Apr 14, 2025
| } | ||
|
|
||
| public static void withFallbackEnabled(Runnable f, String msg) throws IOException { | ||
| System.out.printf("Need fallback to v2 due to %s%n", msg); |
Collaborator
There was a problem hiding this comment.
Is sysout the preferred way to log in test?
Collaborator
Author
There was a problem hiding this comment.
LOG should be better, will change to use LOG.info.
penghuo
previously approved these changes
Apr 14, 2025
LantaoJin
reviewed
Apr 15, 2025
|
|
||
| import org.opensearch.sql.ppl.WhereCommandIT; | ||
|
|
||
| public class CalciteWhereCommandIT extends WhereCommandIT { |
Member
There was a problem hiding this comment.
This PR unify CalciteIT with NonFallbackCalciteIT together, and override tests with fallback for those we've previous ignored in NonFallbackCalcite*IT
Why does this PR only delete one IT file?
Collaborator
Author
There was a problem hiding this comment.
Will migrate others if this approach is acceptable
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
Signed-off-by: Heng Qian <qianheng@amazon.com>
LantaoJin
approved these changes
Apr 15, 2025
penghuo
approved these changes
Apr 15, 2025
penghuo
pushed a commit
that referenced
this pull request
Jun 16, 2025
#3544) * [Calcite Engine] Only enable fallback for tests that need to fall back Signed-off-by: Heng Qian <qianheng@amazon.com> * Address comments Signed-off-by: Heng Qian <qianheng@amazon.com> * Migrate all calcite remote IT and fix incorrectly ignored test Signed-off-by: Heng Qian <qianheng@amazon.com> * Follow the previous action to ignore prometheus test Signed-off-by: Heng Qian <qianheng@amazon.com> --------- Signed-off-by: Heng Qian <qianheng@amazon.com> Signed-off-by: xinyual <xinyual@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to refactoring the current Calcite remote IT. It has drawbacks:
This PR unify Calcite*IT with NonFallbackCalcite*IT together, and override tests with fallback for those we've previous ignored in NonFallbackCalcite*IT
And this PR will also fix the cases where some test/suite have been ignored incorrectly.
Resolves #3546
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.