[BugFix] Fix relevance query function over optimization issue in ReduceExpressionsRule#3851
Merged
qianheng-aws merged 4 commits intoopensearch-project:mainfrom Jul 9, 2025
Conversation
…nsRule Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
songkant-aws
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
dai-chen,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
qianheng-aws
added
bug
qianheng-aws
previously approved these changes
Jul 7, 2025
LantaoJin
reviewed
Jul 7, 2025
| * @param isDeterministic Specified isDeterministic flag | ||
| * @return Calcite SqlUserDefinedFunction | ||
| */ | ||
| default SqlUserDefinedFunction toUDF(String functionName, boolean isDeterministic) { |
Member
There was a problem hiding this comment.
can you combine the methods toUDF in L35? We don't want to keep diff implementations.
| + TEST_INDEX_BEER | ||
| + " | STATS count(AcceptedAnswerId) as idCount" | ||
| + " | WHERE simple_query_string(['Tags'], 'taste') and idCount > 200"; | ||
| + " | EVAL answerId = AcceptedAnswerId + 1" |
Contributor
Author
There was a problem hiding this comment.
Because I think the previous test case semantic is ambiguous simple_query_string can't query on target field right after an aggregation. Use eval operator to simulate a filter that can't be pushed down makes a lot sense.
| } | ||
| } | ||
|
|
||
| private static RexNode derefMapCall(RexNode rexNode) { |
Member
There was a problem hiding this comment.
can you move this method to PlanUtil?
Signed-off-by: Songkan Tang <songkant@amazon.com>
Signed-off-by: Songkan Tang <songkant@amazon.com>
LantaoJin
approved these changes
Jul 8, 2025
qianheng-aws
approved these changes
Jul 9, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 9, 2025
…ceExpressionsRule (#3851) * Fix RelevanceQueryFunction over optimization issue by ReduceExpressionsRule Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix PredicateAnalyzerTest Signed-off-by: Songkan Tang <songkant@amazon.com> * Address comments Signed-off-by: Songkan Tang <songkant@amazon.com> * Fix spotless check Signed-off-by: Songkan Tang <songkant@amazon.com> --------- Signed-off-by: Songkan Tang <songkant@amazon.com> (cherry picked from commit fed92a3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo
pushed a commit
that referenced
this pull request
Jul 9, 2025
…ceExpressionsRule (#3851) (#3858) * Fix RelevanceQueryFunction over optimization issue by ReduceExpressionsRule * Fix PredicateAnalyzerTest * Address comments * Fix spotless check --------- (cherry picked from commit fed92a3) Signed-off-by: Songkan Tang <songkant@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix relevance query function over optimization issue in ReduceExpressionsRule
Related Issues
Related to #3834
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.