Bump ANTLR Version to 4.13.2#5159
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughANTLR dependencies are upgraded from 4.7.1 to 4.13.2 across five Gradle build files. These are dependency-version-only edits; no code, logic, or public API changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ppl/build.gradle (1)
51-55: Centralize the ANTLR version ingradle.properties.
4.13.2is hardcoded in all five updated files, while every other dependency version in the project is driven by a${var}variable. A future bump will again require touching all five files.♻️ Proposed refactor
In
gradle.properties:+antlr_version=4.13.2Then in each
build.gradle:- antlr "org.antlr:antlr4:4.13.2" + antlr "org.antlr:antlr4:${antlr_version}" - implementation "org.antlr:antlr4-runtime:4.13.2" + implementation "org.antlr:antlr4-runtime:${antlr_version}"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ppl/build.gradle` around lines 51 - 55, The ANTLR dependency version is hardcoded as "4.13.2" in the antlr configuration and the implementation dependency; add a single property (e.g. antlrVersion=4.13.2) to gradle.properties and replace the literal "4.13.2" in the antlr declaration and the implementation "org.antlr:antlr4-runtime:4.13.2" with the property reference (e.g. ${antlrVersion}) so all build.gradle files use the centralized antlrVersion; update any other build.gradle files that declare "org.antlr:antlr4" or "org.antlr:antlr4-runtime" to use the same ${antlrVersion} variable.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ppl/build.gradle`:
- Around line 51-55: The ANTLR dependency version is hardcoded as "4.13.2" in
the antlr configuration and the implementation dependency; add a single property
(e.g. antlrVersion=4.13.2) to gradle.properties and replace the literal "4.13.2"
in the antlr declaration and the implementation
"org.antlr:antlr4-runtime:4.13.2" with the property reference (e.g.
${antlrVersion}) so all build.gradle files use the centralized antlrVersion;
update any other build.gradle files that declare "org.antlr:antlr4" or
"org.antlr:antlr4-runtime" to use the same ${antlrVersion} variable.
Signed-off-by: Eric Wei <mengwei.eric@gmail.com>
bd6b9cf to
6b7198d
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ppl/build.gradle (1)
51-55: Consider centralizing the ANTLR version in a shared properties file.The version string
4.13.2is hardcoded independently in fivebuild.gradlefiles. Centralizing it (e.g., ingradle.propertiesor a version cataloglibs.versions.toml) reduces the risk of a partial upgrade next time.#!/bin/bash # Check if a central version catalog or gradle.properties already manages this fd --type f 'gradle.properties' | xargs grep -l "antlr" 2>/dev/null fd --type f 'libs.versions.toml' | xargs grep -l "antlr" 2>/dev/null🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@ppl/build.gradle` around lines 51 - 55, Replace the hardcoded ANTLR version literal "4.13.2" used in declarations like antlr "org.antlr:antlr4:4.13.2" and implementation "org.antlr:antlr4-runtime:4.13.2" with a single centralized property (e.g., add antlrVersion=4.13.2 to gradle.properties or add an entry in libs.versions.toml) and reference that property from this build.gradle; ensure you update the other build.gradle files to use the same centralized variable so all ANTLR artifacts (org.antlr:antlr4 and org.antlr:antlr4-runtime) are driven by one version definition.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@ppl/build.gradle`:
- Around line 51-55: Replace the hardcoded ANTLR version literal "4.13.2" used
in declarations like antlr "org.antlr:antlr4:4.13.2" and implementation
"org.antlr:antlr4-runtime:4.13.2" with a single centralized property (e.g., add
antlrVersion=4.13.2 to gradle.properties or add an entry in libs.versions.toml)
and reference that property from this build.gradle; ensure you update the other
build.gradle files to use the same centralized variable so all ANTLR artifacts
(org.antlr:antlr4 and org.antlr:antlr4-runtime) are driven by one version
definition.
Description
Bump ANTLR4 from 4.7.1 to 4.13.2 across all modules that directly declare it.
Changes
Version updated in 5 modules:
common–antlr4-runtime(api dependency)ppl–antlr4(codegen tool) +antlr4-runtimesql–antlr4(codegen tool) +antlr4-runtimelegacy–antlr4(codegen tool) +antlr4-runtimeasync-query-core–antlr4(codegen tool)Why 4.13.2
Backwards Compatibility
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.