[Feature] Reject aggregations on vectorSearch() relations#5362
Merged
mengweieric merged 2 commits intoopensearch-project:feature/vector-search-p0from Apr 17, 2026
Merged
Conversation
Signed-off-by: Eric Wei <mengwei.eric@gmail.com>
mengweieric
added
SQL
feature
skip-diff-analyzer
mengweieric
requested review from
LantaoJin,
RyanL1997,
Swiddis,
acarbonetto,
ahkcs,
anirudha,
dai-chen,
joshuali925,
noCharger,
penghuo,
ps48,
qianheng-aws,
songkant-aws,
vamsimanohar,
ykmr1224 and
yuancu
as code owners
…are-aggregate ITs; drop subquery workaround text Signed-off-by: Eric Wei <mengwei.eric@gmail.com>
mengweieric
changed the title
ahkcs
approved these changes
Apr 17, 2026
RyanL1997
approved these changes
Apr 17, 2026
5 tasks
mengweieric
merged commit af47e26
into
opensearch-project:feature/vector-search-p0
37 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject aggregations (including
GROUP BYand bare aggregate functions likeCOUNT(*)) onvectorSearch()relations in the SQL preview. This is a SQL-surface constraint, not a native OpenSearch limitation — the k-NN plugin does support aggregations alongside similarity search. The restriction keeps the preview contract narrow and can be lifted in a later release.Changes
VectorSearchIndexScanBuilderoverridespushDownAggregationto throwExpressionEvaluationException.VectorSearchIndex.createScanBuilderreturns the new builder.VectorSearchITtests assert rejection end-to-end:GROUP BYand bareCOUNT(*).Test plan
./gradlew :opensearch:test --tests '*VectorSearchIndexScanBuilderTest'passes./gradlew :integ-test:compileTestJavapasses./gradlew :opensearch:spotlessCheck :integ-test:spotlessCheckpasses