Recordings based on motion detection have no audio.

[stephen-lev]

The recordings based on motion detection have no audio.

The audio packets are dropped in the hls_unified_thread.c

Based on the documentation the motion buffer should store audio as well.
(Am i getting things right?)

[matteius]

I ran this through an agent and got back:

Motion recording architecture: When ONVIF motion is detected, start_mp4_recording_with_trigger("motion") is called, which starts an independent recording thread. That thread opens its own RTSP connection via record_segment() in mp4_segment_recorder.c, which properly handles both audio and video streams. It
does NOT read packets from the HLS thread.

Audio is controlled by record_audio in the stream config (line 185 of mp4_recording_core.c). This defaults to true for new streams. If the user's stream has record_audio=true, audio SHOULD be included in motion recordings.

Potential real causes:

1. The stream's record_audio might be false (older streams created before the default changed)
2. The go2rtc ?video suffix is appended when record_audio=false (line 246), which strips audio at the source
3. The pre-event buffer system (feed_packet_to_event_buffer) is never called and flush_packet_callback has a TODO — but this only affects pre-buffer, not the actual recording