HYPERFLEET-1089 - feat: add WIFConfig TypeSpec model#2
Merged
rh-amarin merged 4 commits intoJun 2, 2026
Merged
Conversation
WIFConfigSpec with version and project_id fields, following Channel resource pattern (APIResource + APIMetadata, name with DNS pattern constraint, generation, ResourceStatus).
POST, GET list, GET by ID, DELETE operations following Channels interface pattern. PATCH intentionally omitted per ticket scope.
kuudori
commented
Jun 1, 2026
| version: string; | ||
|
|
||
| /** GCP project identifier */ | ||
| project_id: string; |
Contributor
Author
There was a problem hiding this comment.
snake_case here, correct? 🤔
kuudori
commented
Jun 1, 2026
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [1.0.20] - 2026-06-01 |
Contributor
Author
There was a problem hiding this comment.
Should we start a new version here? 🤔
Patch version bump for additive WIFConfig resource. Both OpenAPI 3.0 and Swagger 2.0 schemas regenerated and pass spectral lint.
e83b1b8 to
9fedcdc
Compare
Collaborator
|
/lgtm |
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
make test-allpassesmake lintpassesmake test-helm(if applicable)