Skip to content

HYPERFLEET-1017 - refactor: rename Available to LastKnownReconciled and align example reasons #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
May 11, 2026
Merged

HYPERFLEET-1017 - refactor: rename Available to LastKnownReconciled and align example reasons #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd11b21
HYPERFLEET-1017 - chore: restore aliases.tsp symlink and update CLAUD…
rafabene May 11, 2026
b77a76e
HYPERFLEET-1017 - fix: align example reason/message with aggregation …
rafabene May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ alias ClusterSpec = Record<unknown>; // Generic
alias ClusterSpec = GCPClusterSpec; // Provider-specific
```

The `aliases.tsp` symlink determines which provider types are active. The `build-schema.sh` script automatically re-links this during builds.
The `aliases.tsp` symlink determines which provider types are active. The `build-schema.sh` script automatically re-links this during builds. The symlink is tracked in git and should always point to `aliases-core.tsp` by default. Do not remove it from version control or add it to `.gitignore`.
Comment thread
rafabene marked this conversation as resolved.

**When adding new models:**
- Shared models → `models/`
Expand Down Expand Up @@ -188,6 +188,15 @@ alias ClusterSpec = GCPClusterSpec;

Build: `npm run build:gcp`

## Version Bump and Changelog

When bumping the version in `main.tsp`, always update `CHANGELOG.md`:

1. Keep `## [Unreleased]` at the top, then add a new version section as `## [X.Y.Z] - YYYY-MM-DD`
2. List changes under appropriate headings (`Added`, `Changed`, `Fixed`, `Removed`)
3. Update the comparison links at the bottom of the file
4. Follow [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) format

## Validation Checklist

Before submitting changes:
Expand Down
2 changes: 1 addition & 1 deletion main.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ using OpenAPI;
*
*/
@service(#{ title: "HyperFleet API" })
@info(#{ version: "1.0.11", contact: #{ name: "HyperFleet Team" }, license: #{ name: "Apache 2.0" ,url: "https://www.apache.org/licenses/LICENSE-2.0"} })
@info(#{ version: "1.0.12", contact: #{ name: "HyperFleet Team" }, license: #{ name: "Apache 2.0" ,url: "https://www.apache.org/licenses/LICENSE-2.0"} })
@server("https://hyperfleet.redhat.com", "Production")
@route("/api/hyperfleet/v1")
namespace HyperFleet;
Expand Down
10 changes: 5 additions & 5 deletions models/common/model.tsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,11 +244,11 @@ model ResourceCondition {
@format("date-time") last_updated_time: string;
}

const ExampleLastKnownReconciledReason: string = "All required adapters were reconciled at a common observed generation";
const ExampleLastKnownReconciledMessage: string = "All required adapters were reconciled at a common observed generation";
const ExampleReadyReason: string = "All adapters reported Available=True for the current generation";
const ExampleReadyMessage: string = "All adapters reported Available=True for the current generation";
const ExampleReconciledReason: string = "All required adapters reported Available=True or Finalized=True at the current generation";
const ExampleLastKnownReconciledReason: string = "AllAdaptersReconciled";
const ExampleLastKnownReconciledMessage: string = "All required adapters report Available=True for the tracked generation";
const ExampleReadyReason: string = "ReconciledAll";
const ExampleReadyMessage: string = "All required adapters reported Available=True or Finalized=True at the current generation";
const ExampleReconciledReason: string = "ReconciledAll";
Comment thread
coderabbitai[bot] marked this conversation as resolved.
const ExampleReconciledMessage: string = "All required adapters reported Available=True or Finalized=True at the current generation";
const ExampleAdapter1: string = "adapter1";
const ExampleAdapter2: string = "adapter2";
Expand Down
42 changes: 21 additions & 21 deletions schemas/core/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
openapi: 3.0.0
info:
title: HyperFleet API
version: 1.0.11
version: 1.0.12
contact:
name: HyperFleet Team
license:
Expand Down Expand Up @@ -189,24 +189,24 @@ paths:
conditions:
- type: Ready
status: 'True'
reason: All adapters reported Available=True for the current generation
message: All adapters reported Available=True for the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 2
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: Reconciled
status: 'True'
reason: All required adapters reported Available=True or Finalized=True at the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 2
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: LastKnownReconciled
status: 'True'
reason: All required adapters were reconciled at a common observed generation
message: All required adapters were reconciled at a common observed generation
reason: AllAdaptersReconciled
message: All required adapters report Available=True for the tracked generation
observed_generation: 2
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
Expand Down Expand Up @@ -402,24 +402,24 @@ paths:
conditions:
- type: Ready
status: 'True'
reason: All adapters reported Available=True for the current generation
message: All adapters reported Available=True for the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 2
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: Reconciled
status: 'True'
reason: All required adapters reported Available=True or Finalized=True at the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 2
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: LastKnownReconciled
status: 'True'
reason: All required adapters were reconciled at a common observed generation
message: All required adapters were reconciled at a common observed generation
reason: AllAdaptersReconciled
message: All required adapters report Available=True for the tracked generation
observed_generation: 2
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
Expand Down Expand Up @@ -1174,24 +1174,24 @@ components:
conditions:
- type: Ready
status: 'True'
reason: All adapters reported Available=True for the current generation
message: All adapters reported Available=True for the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 1
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: Reconciled
status: 'True'
reason: All required adapters reported Available=True or Finalized=True at the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 1
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: LastKnownReconciled
status: 'True'
reason: All required adapters were reconciled at a common observed generation
message: All required adapters were reconciled at a common observed generation
reason: AllAdaptersReconciled
message: All required adapters report Available=True for the tracked generation
observed_generation: 1
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
Expand Down Expand Up @@ -1473,24 +1473,24 @@ components:
conditions:
- type: Ready
status: 'True'
reason: All adapters reported Available=True for the current generation
message: All adapters reported Available=True for the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 1
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: Reconciled
status: 'True'
reason: All required adapters reported Available=True or Finalized=True at the current generation
reason: ReconciledAll
message: All required adapters reported Available=True or Finalized=True at the current generation
observed_generation: 1
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
- type: LastKnownReconciled
status: 'True'
reason: All required adapters were reconciled at a common observed generation
message: All required adapters were reconciled at a common observed generation
reason: AllAdaptersReconciled
message: All required adapters report Available=True for the tracked generation
observed_generation: 1
created_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
Expand Down
74 changes: 29 additions & 45 deletions schemas/core/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ info:
name: Apache 2.0
url: 'https://www.apache.org/licenses/LICENSE-2.0'
title: HyperFleet API
version: 1.0.11
version: 1.0.12
host: hyperfleet.redhat.com
basePath: /
schemes:
Expand Down Expand Up @@ -158,12 +158,10 @@ paths:
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: >-
All adapters reported Available=True for the current
generation
All required adapters reported Available=True or
Finalized=True at the current generation
observed_generation: 2
reason: >-
All adapters reported Available=True for the current
generation
reason: ReconciledAll
status: 'True'
type: Ready
- created_time: '2021-01-01T10:00:00Z'
Expand All @@ -173,21 +171,17 @@ paths:
All required adapters reported Available=True or
Finalized=True at the current generation
observed_generation: 2
reason: >-
All required adapters reported Available=True or
Finalized=True at the current generation
reason: ReconciledAll
status: 'True'
type: Reconciled
- created_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: >-
All required adapters were reconciled at a common observed
generation
All required adapters report Available=True for the
tracked generation
observed_generation: 2
reason: >-
All required adapters were reconciled at a common observed
generation
reason: AllAdaptersReconciled
status: 'True'
type: LastKnownReconciled
- created_time: '2021-01-01T10:00:00Z'
Expand Down Expand Up @@ -455,12 +449,10 @@ paths:
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: >-
All adapters reported Available=True for the current
generation
All required adapters reported Available=True or
Finalized=True at the current generation
observed_generation: 2
reason: >-
All adapters reported Available=True for the current
generation
reason: ReconciledAll
status: 'True'
type: Ready
- created_time: '2021-01-01T10:00:00Z'
Expand All @@ -470,21 +462,17 @@ paths:
All required adapters reported Available=True or
Finalized=True at the current generation
observed_generation: 2
reason: >-
All required adapters reported Available=True or
Finalized=True at the current generation
reason: ReconciledAll
status: 'True'
type: Reconciled
- created_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: >-
All required adapters were reconciled at a common observed
generation
All required adapters report Available=True for the
tracked generation
observed_generation: 2
reason: >-
All required adapters were reconciled at a common observed
generation
reason: AllAdaptersReconciled
status: 'True'
type: LastKnownReconciled
- created_time: '2021-01-01T10:00:00Z'
Expand Down Expand Up @@ -1273,9 +1261,11 @@ definitions:
- created_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: All adapters reported Available=True for the current generation
message: >-
All required adapters reported Available=True or Finalized=True at
the current generation
observed_generation: 1
reason: All adapters reported Available=True for the current generation
reason: ReconciledAll
status: 'True'
type: Ready
- created_time: '2021-01-01T10:00:00Z'
Expand All @@ -1285,21 +1275,17 @@ definitions:
All required adapters reported Available=True or Finalized=True at
the current generation
observed_generation: 1
reason: >-
All required adapters reported Available=True or Finalized=True at
the current generation
reason: ReconciledAll
status: 'True'
type: Reconciled
- created_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: >-
All required adapters were reconciled at a common observed
All required adapters report Available=True for the tracked
generation
observed_generation: 1
reason: >-
All required adapters were reconciled at a common observed
generation
reason: AllAdaptersReconciled
status: 'True'
type: LastKnownReconciled
- created_time: '2021-01-01T10:00:00Z'
Expand Down Expand Up @@ -1599,9 +1585,11 @@ definitions:
- created_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: All adapters reported Available=True for the current generation
message: >-
All required adapters reported Available=True or Finalized=True at
the current generation
observed_generation: 1
reason: All adapters reported Available=True for the current generation
reason: ReconciledAll
status: 'True'
type: Ready
- created_time: '2021-01-01T10:00:00Z'
Expand All @@ -1611,21 +1599,17 @@ definitions:
All required adapters reported Available=True or Finalized=True at
the current generation
observed_generation: 1
reason: >-
All required adapters reported Available=True or Finalized=True at
the current generation
reason: ReconciledAll
status: 'True'
type: Reconciled
- created_time: '2021-01-01T10:00:00Z'
last_transition_time: '2021-01-01T10:00:00Z'
last_updated_time: '2021-01-01T10:00:00Z'
message: >-
All required adapters were reconciled at a common observed
All required adapters report Available=True for the tracked
generation
observed_generation: 1
reason: >-
All required adapters were reconciled at a common observed
generation
reason: AllAdaptersReconciled
status: 'True'
type: LastKnownReconciled
- created_time: '2021-01-01T10:00:00Z'
Expand Down
Loading