Skip to content

HYPERFLEET-1167 - feat: update swagger-ui and add integrity attributes#57

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
rh-amarin:HYPERFLEET-1167
Jun 2, 2026
Merged

HYPERFLEET-1167 - feat: update swagger-ui and add integrity attributes#57
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
rh-amarin:HYPERFLEET-1167

Conversation

@rh-amarin
Copy link
Copy Markdown
Collaborator

Summary

Update swagger-ui for latest version and include integrity html attribute to linked files for better security

@openshift-ci openshift-ci Bot requested review from aredenba-rh and vkareh June 2, 2026 15:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 723e5645-7250-4364-86c4-9a0e23cba4da

📥 Commits

Reviewing files that changed from the base of the PR and between 05f859b and f906938.

📒 Files selected for processing (4)
  • README.md
  • core.html
  • gcp.html
  • index.html
💤 Files with no reviewable changes (2)
  • gcp.html
  • core.html

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Updated README to direct users to browse the API specification via Swagger UI on GitHub Pages.
  • Chores

    • Removed legacy HTML files, consolidating to a single Swagger UI interface.
    • Updated Swagger UI configuration with enhanced features and updated specification reference.

Walkthrough

This PR consolidates multiple Swagger UI pages (core.html, gcp.html) into a single index.html entry point hosted via GitHub Pages. The index.html is upgraded from swagger-ui-dist v4.4.1 to v5.32.6 with security improvements (SRI integrity attributes), updated spec URL pointing to the new core contract location, and enhanced configuration (deepLinking, presets, standalone layout). README documentation is updated to direct users to the new consolidated page.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the main changes: updating swagger-ui and adding integrity attributes to HTML files.
Description check ✅ Passed The description directly relates to the changeset, mentioning swagger-ui version updates and integrity attributes, which match the actual file modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PR modifies only HTML/Markdown files. No Go source files with logging statements are modified; schemas.go contains no logging calls.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

@rafabene
Copy link
Copy Markdown
Contributor

rafabene commented Jun 2, 2026

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Jun 2, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 61f6091 into openshift-hyperfleet:main Jun 2, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants