HYPERFLEET-1016 - refactor: Fix remaining Ready references#89
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe pull request converts readiness checks from a phase-based model to a condition-based model across tests, configs, code, and docs. Timeouts and struct fields in pkg/config were renamed from Ready → Reconciled and defaults updated accordingly. E2E tests for clusters and nodepools now call WaitForClusterCondition/WaitForNodePoolCondition and use Reconciled timeouts. Configuration examples and documentation (CLAUDE.md, docs/architecture.md, docs/development.md, user journeys, and API E2E scenarios) were updated to reference the Reconciled condition. Several deprecated test-case Markdown files were removed. Sequence Diagram(s)sequenceDiagram
participant Test as Test Suite / Helper
participant API as HyperFleet API / Controller
participant Adap as Adapters
participant K8s as Kubernetes / Status Store
Test->>API: Create Cluster request
API->>K8s: Persist Cluster resource (generation N)
Adap->>K8s: Start adapter work for generation N
Test->>API: WaitForClusterCondition(Reconciled=True, timeout=h.Cfg.Timeouts.Cluster.Reconciled)
loop Polling
Test->>API: Get Cluster status (generation N)
API->>K8s: Read Cluster conditions
K8s-->>API: Return conditions (Reconciled: False/True)
API-->>Test: Return current conditions
end
Adap->>K8s: Update adapter condition(s) -> may set Reconciled=True when all complete
K8s-->>API: Updated conditions
API-->>Test: Reconciled=True (Test proceeds)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/development.md`:
- Around line 97-99: The example uses client.ConditionTypeReconciled but the
import block is missing the package; update the Go example's imports to include
"github.com/openshift-hyperfleet/hyperfleet-e2e/pkg/client" so references like
client.ConditionTypeReconciled compile, ensuring the import is added alongside
the existing imports in the example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 8502e191-8796-4ccc-9b65-f2c1a533ed5c
📒 Files selected for processing (18)
CLAUDE.mdconfigs/config.yamldocs/architecture.mddocs/development.mde2e/cluster/concurrent_creation.goe2e/cluster/crash_recovery.goe2e/cluster/creation.goe2e/nodepool/concurrent_creation.goe2e/nodepool/creation.gopkg/config/config.gopkg/config/defaults.gotest-design/testcases/cluster-deprecated/adapter-statuses.mdtest-design/testcases/cluster-deprecated/create-cluster.mdtest-design/testcases/delete-cluster.mdtest-design/testcases/nodepool-deprecated/create-nodepool.mdtest-design/user-journeys/hyperfleet-adapter-cuj.mdtest-design/user-journeys/hyperfleet-api-cuj.mdtest-design/user-journeys/hyperfleet-api-e2e-scenario.md
💤 Files with no reviewable changes (3)
- test-design/testcases/cluster-deprecated/create-cluster.md
- test-design/testcases/cluster-deprecated/adapter-statuses.md
- test-design/testcases/nodepool-deprecated/create-nodepool.md
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rafabene The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 591aebd
into
openshift-hyperfleet:main
2 participants
Summary
Follow-up to PR #87. Addresses remaining Slack review feedback:
WaitForClusterPhase()/openapi.Ready/Status.Phasecode examples withWaitForClusterCondition()/ConditionTypeReconciled/HasResourceCondition— these referenced API features removed in HYPERFLEET-386 (Jan 2026)Not Ready/Ready) to condition terminology (Reconciled=False/Reconciled=True)ReadytoReconciledacross Go structs, YAML keys, env vars, defaults, and all consuming codecluster-deprecated/,nodepool-deprecated/) that referenced the removedstatus.phasefieldScope
Stale code examples (3 files):
CLAUDE.md,docs/architecture.md,docs/development.mdUser journey docs (3 files, ~60 lines):
test-design/user-journeys/hyperfleet-api-cuj.mdtest-design/user-journeys/hyperfleet-api-e2e-scenario.mdtest-design/user-journeys/hyperfleet-adapter-cuj.mdTimeout field rename
Ready→Reconciled(9 files):pkg/config/config.go— struct fields, defaults, loggingpkg/config/defaults.go— constant namesconfigs/config.yaml— YAML keys, env var namese2e/cluster/creation.go,concurrent_creation.go,crash_recovery.goe2e/nodepool/creation.go,concurrent_creation.gotest-design/testcases/delete-cluster.mdDeprecated test docs deleted (3 files, -1,352 lines):
test-design/testcases/cluster-deprecated/adapter-statuses.mdtest-design/testcases/cluster-deprecated/create-cluster.mdtest-design/testcases/nodepool-deprecated/create-nodepool.mdBreaking changes
HYPERFLEET_TIMEOUTS_CLUSTER_READY→HYPERFLEET_TIMEOUTS_CLUSTER_RECONCILED,HYPERFLEET_TIMEOUTS_NODEPOOL_READY→HYPERFLEET_TIMEOUTS_NODEPOOL_RECONCILEDready:→reconciled:undertimeouts.clusterandtimeouts.nodepoolTest plan
make buildpassesmake lint— 0 issuesmake test— all unit tests passSummary by CodeRabbit
Configuration Changes
Documentation
Tests