HYPERFLEET-1068 - fix: whitelist bot authors in commitlint validation

[ciaranRoche]

Summary

• Adds author-based whitelisting to the commitlint validator so commits from known bot accounts (e.g., Konflux) are automatically skipped during validation
• Whitelists both commit author email (git path) and PR author login (GitHub API path)
• Removes unused getCommitMessage function (logic inlined in validateCommits)
• Adds AuthorEmail to PRCommit and refactors GetPRTitle to GetPRInfo to include PR author login
• Adds tests for whitelist behaviour in both git and validator paths

Problem

Konflux PaC sends onboarding PRs with commit messages like Red Hat Konflux kflux-prd-rh02 update hyperfleet-api which fail the HyperFleet commit standard. Both the commit message AND the PR title fail validation, blocking merge of .tekton/ pipeline files on all three component repos.

Approach

Whitelist by author identity rather than commit message pattern — bot identities are stable, messages could change. Whitelisted commits and PR titles print SKIP (whitelisted author: ...) and count as passed.

Currently whitelisted:

• konflux@no-reply.konflux-ci.dev (commit author email)
• red-hat-konflux-kflux-prd-rh02[bot] (GitHub PR author login)

Manual Verification

Built locally and ran against the actual Konflux onboarding PR (hyperfleet-api #132):

$ PULL_BASE_SHA=0f2e440 PULL_PULL_SHA=165fe1e REPO_OWNER=openshift-hyperfleet \
  REPO_NAME=hyperfleet-api PULL_NUMBER=132 ./hyperfleet-hooks commitlint --pr

🔍 Validating commits in range: 0f2e440..165fe1e
📝 Found 1 commit(s) to validate

Checking: 165fe1ed - Red Hat Konflux kflux-prd-rh02 update hyperfleet-api
  ⏭️  SKIP (whitelisted author: konflux@no-reply.konflux-ci.dev)

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
📋 Validating PR title...
PR #132: Red Hat Konflux kflux-prd-rh02 update hyperfleet-api
  ⏭️  SKIP (whitelisted author: red-hat-konflux-kflux-prd-rh02[bot])

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✅ All 1 commit(s) passed validation!
✅ PR title passed validation!
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

Follow-up

After this merges and a new release is cut, the Prow presubmit job in openshift/release needs updating to use the new version.

Test plan

• TestValidator_IsWhitelistedAuthor — unit tests for whitelist lookup (email, GitHub login, case insensitive, empty, non-whitelisted)
• TestValidateCommits_WhitelistedAuthor — integration test: bot commit skipped, user commit validated
• TestValidateCommits_WhitelistedAuthorInvalidMessage — non-whitelisted author with bad message still fails
• TestGetPRInfo_InvalidRepoFormat — updated from GetPRTitle
• TestGetPRInfoFromEnv_MissingEnvVars — updated from GetPRTitleFromEnv
• All existing tests pass

🤖 Generated with Claude Code

[rh-amarin]

/lgtm