Skip to content

fix(deploy): use /metrics path for SpiceDB health probes#438

Merged
jsell-rh merged 1 commit intomainfrom
jsell/fix/spicedb-metrics-probe
Apr 23, 2026
Merged

fix(deploy): use /metrics path for SpiceDB health probes#438
jsell-rh merged 1 commit intomainfrom
jsell/fix/spicedb-metrics-probe

Conversation

@jsell-rh
Copy link
Copy Markdown
Collaborator

@jsell-rh jsell-rh commented Apr 23, 2026

Summary

The previous probe change (#436) used path: / on port 9090 which returns 404. SpiceDB's metrics endpoint is at /metrics.

Verified locally: curl http://localhost:9091/metrics returns HTTP 200 on plaintext port 9090 even with gRPC TLS enabled.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated health check configuration for improved service reliability and monitoring.

Verified locally: /metrics returns HTTP 200 on plaintext port 9090.
gRPC probes on 50051 time out due to TLS handshake.
HTTP gateway on 8443 returns 404 on root path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 88045172-22b0-49cd-87d8-68a94734c1e4

📥 Commits

Reviewing files that changed from the base of the PR and between 6353566 and 6daca0b.

📒 Files selected for processing (1)
  • deploy/apps/kartograph/base/spicedb-deployment.yaml

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting


Walkthrough

Modified the health check configuration for the spicedb container in the Kubernetes deployment manifest. Replaced gRPC-based probes that targeted port 50051 with HTTP-based probes that perform GET requests to the /metrics endpoint on port 9090. The change was applied to both the livenessProbe and readinessProbe fields. All existing timing and threshold parameters were preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jsell/fix/spicedb-metrics-probe

Comment @coderabbitai help to get the list of available commands and usage tips.

@jsell-rh jsell-rh merged commit b442785 into main Apr 23, 2026
7 of 8 checks passed
@jsell-rh jsell-rh deleted the jsell/fix/spicedb-metrics-probe branch April 23, 2026 17:52
jsell-rh added a commit that referenced this pull request May 2, 2026
…#438)

Verified locally: /metrics returns HTTP 200 on plaintext port 9090.
gRPC probes on 50051 time out due to TLS handshake.
HTTP gateway on 8443 returns 404 on root path.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jsell-rh added a commit that referenced this pull request May 2, 2026
…#438)

Verified locally: /metrics returns HTTP 200 on plaintext port 9090.
gRPC probes on 50051 time out due to TLS handshake.
HTTP gateway on 8443 returns 404 on root path.

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant