Skip to content

Conversation

@kaldesai
Copy link
Contributor

@kaldesai kaldesai commented Sep 14, 2023

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-165

Doc preview:
Please check the following sections:

The overview conveys that this URL covers information that is DP and TP and the respective section mentions that they are TP or DP respectively

@openshift-ci-robot
Copy link

@kaldesai: This pull request references SRVLOGIC-165 which is a valid jira issue.

In response to this:

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-165

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name Link
🔨 Latest commit a2996b8
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/6503f457e78f7600085b74d0
😎 Deploy Preview https://deploy-preview-99--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci-robot
Copy link

@kaldesai: This pull request references SRVLOGIC-165 which is a valid jira issue.

In response to this:

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-165

Doc preview: https://deploy-preview-99--jazzy-shortbread-5f62b7.netlify.app/docs/latest/index.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

OpenShift Serverless provides information about additional, advanced use cases and integrations that are possible using OpenShift Container Platform and OpenShift Serverless, but are for technology and development purposes and are not officially supported by Red Hat.
OpenShift Serverless is a Technology Preview feature only. Technology Preview features are not supported with Red Hat production service level agreements (SLAs) and might not be functionally complete. Red Hat does not recommend using them in production. These features provide early access to upcoming product features, enabling customers to test functionality and provide feedback during the development process.
Copy link

@Preeticp Preeticp Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. @kaldesai please remove the paragraph from line 11. The rest of the content looks good from the over view pov.
  2. In https://deploy-preview-99--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-eventing/service-mesh/eventing-service-mesh-setup, and https://deploy-preview-99--jazzy-shortbread-5f62b7.netlify.app/docs/latest/functions/serverless-functions-about sections, please add notes which provide Developer Preview related disclaimer:
    OpenShift Serverless - Developer Preview releases contain features and functionalities that might not be fully tested. Customers are encouraged to provide feedback on Developer Preview releases.
    Developer Preview releases are not production-ready, and customers are recommended to avoid using the project for production or business-critical workloads.
  3. In https://deploy-preview-99--jazzy-shortbread-5f62b7.netlify.app/docs/latest/serverless-logic/about please add the Technology preview related note:
    'Technology Preview features are not supported with Red Hat production service level agreements (SLAs) and might not be functionally complete. Red Hat does not recommend using them in production.
    These features provide early access to upcoming product features, enabling customers to test functionality and provide feedback during the development process.'

Basically, the overview conveys that this site covers info that is DP and TP and the respective section mention that they are TP or DP respectively.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have incorporated all of your changes.

@openshift-ci-robot
Copy link

@kaldesai: This pull request references SRVLOGIC-165 which is a valid jira issue.

In response to this:

Tracking JIRA: https://issues.redhat.com/browse/SRVLOGIC-165

Doc preview:
Please check the following sections:

The overview conveys that this URL covers information that is DP and TP and the respective section mentions that they are TP or DP respectively

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Preeticp
Copy link

LGTM. I think this is ready to be merged.

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaldesai, krisv, ricardozanini

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaldesai kaldesai changed the title [WIP] PR for SRVLOGIC-165: Add a tech preview note and change the title to Technology and Developer Preview releases PR for SRVLOGIC-165: Add a tech preview note and change the title to Technology and Developer Preview releases Sep 15, 2023
@kaldesai
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci
Copy link

openshift-ci bot commented Sep 15, 2023

@kaldesai: The label(s) /label merge-review-needed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaldesai
Copy link
Contributor Author

There were conflicts in this PR related to Serverless + Service Mesh integration. So I created a new PR to track all the updated changes Closing this one.
PR: #101

@kaldesai kaldesai closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants