Add option to specify Golang default version#911
Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift-knative:mainfrom Mar 3, 2026
Merged
Add option to specify Golang default version#911openshift-merge-bot[bot] merged 3 commits intoopenshift-knative:mainfrom
openshift-merge-bot[bot] merged 3 commits intoopenshift-knative:mainfrom
Conversation
dsimansk
reviewed
Mar 2, 2026
| // If no repo-branch specific config is set, it uses the one from the coresponding SO branch config. | ||
| // If SO does not have a default go version in it's config neither it uses the go version from the | ||
| // repositories go.mod file. | ||
| func goVersion(goModGoVersion string, metadata *project.Metadata) (string, error) { |
Contributor
There was a problem hiding this comment.
I'd consider returning (*string, error) and then work with nil, nil return in the generator to avoid additional input variable goModGoVersion string.
Contributor
There was a problem hiding this comment.
EOD it isn't simplifying a whole lot, so no hard opinion either way.
dsimansk
reviewed
Mar 2, 2026
Contributor
|
/approve if comments need to be addressed |
Collaborator
Author
|
/unhold |
Contributor
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
df6334f
into
openshift-knative:main
4 checks passed
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the Go version for the dockerfiles is parsed from the go.mod file. This can lead to issues, when different components for a specific SO version lack behind (e.g. eventing is on 1.23, while SO requires through some dependencies 1.25, would lead to build issues for eventing).
This PR addresses it and allows to specify the default Golang version through the config files. It has the following order: