Skip to content

CNF-19629: T159: Follow best practices for secure error and exception handling#195

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-kni:mainfrom
aabughosh:errhandle
Oct 21, 2025
Merged

CNF-19629: T159: Follow best practices for secure error and exception handling#195
openshift-merge-bot[bot] merged 1 commit intoopenshift-kni:mainfrom
aabughosh:errhandle

Conversation

@aabughosh
Copy link
Collaborator

This PR aligns the code with the best practices for secure error handling, as part of CNF-19629

Added a centralized error handler in main to ensure consistent and secure error reporting.

Updated functions to return errors instead of exposing sensitive details or performing direct logging.

Ensured that sensitive information is not leaked through logs or error messages.

This improves both security and maintainability of the code by standardizing how errors are propagated and handled.

@openshift-ci-robot
Copy link

@aabughosh: This pull request references CNF-19629 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This PR aligns the code with the best practices for secure error handling, as part of CNF-19629

Added a centralized error handler in main to ensure consistent and secure error reporting.

Updated functions to return errors instead of exposing sensitive details or performing direct logging.

Ensured that sensitive information is not leaked through logs or error messages.

This improves both security and maintainability of the code by standardizing how errors are propagated and handled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@aabughosh
Copy link
Collaborator Author

/retest

Copy link
Member

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aabughosh, greyerof, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@aabughosh
Copy link
Collaborator Author

/retest

2 similar comments
@aabughosh
Copy link
Collaborator Author

/retest

@aabughosh
Copy link
Collaborator Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit aa24bf2 into openshift-kni:main Oct 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants