Skip to content

Conversation

@stbenjam
Copy link
Member

@stbenjam stbenjam commented Jul 7, 2021

Currently, IPv6 clusters do not synchronize their time with NTP because
there's no external internet access. This is causing a newly enabled
test to fail ([sig-apps] [Feature:TTLAfterFinished] job should be deleted once it finishes after TTL seconds).

@openshift-ci openshift-ci bot requested review from derekhiggins and flaper87 July 7, 2021 13:45
@stbenjam
Copy link
Member Author

stbenjam commented Jul 7, 2021

/test e2e-metal-ipi

Packet failure.

@stbenjam
Copy link
Member Author

stbenjam commented Jul 7, 2021

/test e2e-metal-ipi

@hardys
Copy link

hardys commented Jul 8, 2021

lgtm, just a question about whether we can restrict the firewall rule to avoid exposing chronyd outside the test host by default

Currently, IPv6 clusters do not synchronize their time with NTP because
there's no external internet access. This is causing a newly enabled
test to fail (`[sig-apps] [Feature:TTLAfterFinished] job should be deleted once it finishes after TTL seconds`).
@stbenjam
Copy link
Member Author

stbenjam commented Jul 8, 2021

@hardys Could you take another look? Thanks!

@hardys
Copy link

hardys commented Jul 8, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@hardys
Copy link

hardys commented Jul 8, 2021

/retest

Copy link
Contributor

@sadasu sadasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@stbenjam
Copy link
Member Author

stbenjam commented Jul 9, 2021

/retest

3 similar comments
@ardaguclu
Copy link
Contributor

/retest

@stbenjam
Copy link
Member Author

stbenjam commented Jul 9, 2021

/retest

@stbenjam
Copy link
Member Author

stbenjam commented Jul 9, 2021

/retest

@stbenjam
Copy link
Member Author

stbenjam commented Jul 9, 2021

/test e2e-metal-ipi-ovn-ipv6

1 similar comment
@stbenjam
Copy link
Member Author

stbenjam commented Jul 9, 2021

/test e2e-metal-ipi-ovn-ipv6

@openshift-merge-robot openshift-merge-robot merged commit 2bd8da6 into openshift-metal3:master Jul 9, 2021
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Jul 16, 2021
This was added in openshift-metal3#1274 but doing this drops all the libvirt chains,
which causes subsequent ansible libvirt setup tasks to fail.
hardys pushed a commit to hardys/dev-scripts that referenced this pull request Jul 16, 2021
This was added in openshift-metal3#1274 but doing this drops all the libvirt chains,
which causes subsequent ansible libvirt setup tasks to fail.
openshift-merge-robot pushed a commit that referenced this pull request Jul 27, 2021
This was added in #1274 but doing this drops all the libvirt chains,
which causes subsequent ansible libvirt setup tasks to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants