Skip to content

Add Alma and Rocky Linux as supported host OSes #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Aug 24, 2022
Merged

Add Alma and Rocky Linux as supported host OSes #1348

openshift-merge-robot merged 1 commit into from
Aug 24, 2022

Conversation

@cybertron
Copy link
Contributor

@cybertron cybertron commented Feb 3, 2022

These two distributions are essentially what CentOS was pre-Stream,
so they should generally be compatible as well. They are documented
as "best effort" support though since I don't think we'll be running
them in CI.

@openshift-ci openshift-ci bot requested review from andfasano and russellb February 3, 2022 17:54
@cybertron
Copy link
Contributor Author

cybertron commented Feb 3, 2022

/hold

This got it past the validation stage, but something failed later on. Looks like I need to make further changes.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2022
@andfasano
Copy link
Member

andfasano commented Feb 3, 2022

Note that the default packet setup step creates an instance with Centos8.
If you want something else, you'll need at least a temporary test where you could set the PACKET_OS variable as required

@cybertron
Copy link
Contributor Author

cybertron commented Mar 22, 2022

Okay, this one is working for me locally on Alma. Had to get a little hacky with the ansible python interpreter, but that should be a temporary thing until Ansible fixes it properly.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@cybertron
Copy link
Contributor Author

cybertron commented Apr 4, 2022

/retest-required

@elfosardo
Copy link
Member

elfosardo commented Apr 5, 2022

/retest

elfosardo
elfosardo suggested changes Apr 5, 2022
View reviewed changes
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2022
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2022
@cybertron
Copy link
Contributor Author

cybertron commented Jun 2, 2022

/retest-required

1 similar comment
@cybertron
Copy link
Contributor Author

cybertron commented Jun 14, 2022

/retest-required

@cybertron
Copy link
Contributor Author

cybertron commented Jun 16, 2022

/retest

Some of these jobs are no longer required, and I think all of the required ones have passed.

@cybertron
Copy link
Contributor Author

cybertron commented Jun 24, 2022

/retest-required

Looks like issues getting a test environment.

@danwinship
Copy link
Contributor

danwinship commented Jul 21, 2022

any reason this hasn't merged? CentOS 8 on Equinix no longer seems to work for me:

[root@dwinship ~]# dnf -y install git jq make
CentOS Linux 8 - AppStream                                            1.5 kB/s |  38  B     00:00    
Error: Failed to download metadata for repo 'appstream': Cannot prepare internal mirrorlist: No URLs in mirrorlist

@danwinship
Copy link
Contributor

danwinship commented Jul 21, 2022

hm... nor does Rocky even with this PR:

The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_ansible.posix.selinux_payload_btu2jecb/ansible_ansible.posix.selinux_payload.zip/ansible_collections/ansible/posix/plugins/modules/selinux.py", line 100, in <module>
ModuleNotFoundError: No module named 'selinux'
fatal: [localhost]: FAILED! => {
    "changed": false,
    "invocation": {
        "module_args": {
            "configfile": "/etc/selinux/config",
            "policy": "targeted",
            "state": "permissive",
            "update_kernel_param": false
        }
    },
    "msg": "Failed to import the required Python library (libselinux-python) on dwinship's Python /bin/python3.9. Please read the module documentation and install it in the appropriate location. If the required library is installed, but Ansible is using the wrong Python interpreter, please consult the documentation on ansible_python_interpreter"
}

python3-libselinux is installed though...

@cybertron
Copy link
Contributor Author

cybertron commented Jul 21, 2022

Ah, that sounds like the same problem I ran into with Alma. Maybe the Python interpreter workaround is needed for Rocky too. I thought someone had already fixed that for Rocky but maybe not. I need to rebase this anyway, so I'll add Rocky to the conditional so you can try it.

@elfosardo
Copy link
Member

elfosardo commented Jul 22, 2022

/retest

@danwinship
Copy link
Contributor

danwinship commented Jul 22, 2022

I'll add Rocky to the conditional so you can try it.

I retried using Alma and it worked, and I managed to test what I was testing. I do need to go back and test an updated patch at some point but I'm not sure when I'm going to get to that...

@danwinship
Copy link
Contributor

danwinship commented Jul 23, 2022

/lgtm
works with Rocky now too

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2022
@dtantsur
Copy link
Member

dtantsur commented Jul 26, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jul 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@elfosardo
Copy link
Member

elfosardo commented Jul 27, 2022

/retest

@cybertron
Copy link
Contributor Author

cybertron commented Jul 27, 2022

/retest-required

Infra failure

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2022
@elfosardo elfosardo mentioned this pull request Jul 28, 2022
Merged
@cybertron
Add Alma and Rocky Linux as supported host OSes
351ae8a 
These two distributions are essentially what CentOS was pre-Stream,
so they should generally be compatible as well. They are documented
as "best effort" support though since I don't think we'll be running
them in CI.

For Alma, Ansible does not correctly detect the python interpreter
so we need to explicitly override it on calls to ansible-playbook.
We can't do it in a config file because it's explicitly set in the
metal3-dev-env inventory, so we need to use a method that will take
precedence over that. This workaround can be removed once Ansible
has proper support for Python detection on Alma.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 22, 2022
@cybertron
Copy link
Contributor Author

cybertron commented Aug 22, 2022

Rebased to account for some recent changes in OS setup.

@cybertron
Copy link
Contributor Author

cybertron commented Aug 23, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2022

@cybertron: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-proxy-ipv6 ec42b87 link false /test e2e-metal-ipi-proxy-ipv6
ci/prow/e2e-metal-ipi-proxy-ipv4 ec42b87 link false /test e2e-metal-ipi-proxy-ipv4
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 351ae8a link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@elfosardo
Copy link
Member

elfosardo commented Aug 24, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4e4d40b into openshift-metal3:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andfasano andfasano Awaiting requested review from andfasano

@russellb russellb Awaiting requested review from russellb

1 more reviewer

@elfosardo elfosardo elfosardo requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@danwinship danwinship

@elfosardo elfosardo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cybertron @andfasano @elfosardo @danwinship @dtantsur @openshift-merge-robot