OCPEDGE-2463: fix(cluster): add local registry CA trust when MIRROR_IMAGES is enabled

[jaypoulz]

IPv6 deployments default to MIRROR_IMAGES=true but the local registry CA trust patch only ran when ENABLE_LOCAL_REGISTRY was explicitly set. This caused CAPI to crashloop with x509 certificate errors when pulling from the local registry.

This fix aligns the condition with the pattern used elsewhere in the codebase (utils.sh:150, 474, network.sh:206) to check if MIRROR_IMAGES is active, ensuring the trust bundle is added whenever the local registry is actually in use.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zaneb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @jaypoulz. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jaypoulz]

Code Rabbit's review 🐰

(default) jpoulin@fedora:~/Projects/jaypoulz/dev-scripts$ coderabbit review --base-commit ec1726827c5c899c54fb074c13e57601593dbfc9

Tip: Use --interactive to start in interactive mode.

Starting CodeRabbit review in plain text mode...

Connecting to review service
Setting up
Summarizing
Reviewing

Review completed: No findings ✔
(default) jpoulin@fedora:~/Projects/jaypoulz/dev-scripts$ git log
commit 9a6aa66a806c042b97545e0211918d08dc3c4d54 (HEAD -> OCPEDGE-2463-ipv6-mirror-trust-local-registry, origin/OCPEDGE-2463-ipv6-mirror-trust-local-registry)
Author: Jeremy Poulin <jaypoulz@gmail.com>
Date:   Tue Apr 7 14:33:10 2026 -0400

    OCPEDGE-2463: fix(cluster): add local registry CA trust when MIRROR_IMAGES is enabled
    
    IPv6 deployments default to MIRROR_IMAGES=true but the local registry CA
    trust patch only ran when ENABLE_LOCAL_REGISTRY was explicitly set. This
    caused CAPI to crashloop with x509 certificate errors when pulling from
    the local registry.
    
    This fix aligns the condition with the pattern used elsewhere in the
    codebase (utils.sh:150, 474, network.sh:206) to check if MIRROR_IMAGES
    is active, ensuring the trust bundle is added whenever the local registry
    is actually in use.
    
    Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
    
    Made-with: Cursor
    Agent: Auto

commit ec1726827c5c899c54fb074c13e57601593dbfc9 (upstream/master, upstream/HEAD)
Author: Bob Fournie <bfournie@redhat.com>
Date:   Mon Apr 6 20:15:11 2026 -0400

    OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page (#1881)

[dtantsur]

/ok-to-test

[openshift-ci]

@jaypoulz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	9a6aa66	link	true	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.