Skip to content

NO-JIRA: fix: populate AGENT_MASTER_HOSTNAMES in configure_node#1886

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-metal3:masterfrom
fracappa:fca/add-master-configure_node
Apr 28, 2026
Merged

NO-JIRA: fix: populate AGENT_MASTER_HOSTNAMES in configure_node#1886
openshift-merge-bot[bot] merged 1 commit intoopenshift-metal3:masterfrom
fracappa:fca/add-master-configure_node

Conversation

@fracappa
Copy link
Copy Markdown
Contributor

This is a small fix following #1885 patch

@openshift-ci openshift-ci Bot requested review from bfournie and rwsu April 24, 2026 11:22
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 24, 2026

Hi @fracappa. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2026
@elfosardo
Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2026
@dtantsur
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2026
@elfosardo
Copy link
Copy Markdown
Member

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit f6b41d7 into openshift-metal3:master Apr 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants