Improving UX around gcloud iam api consistency model #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckandag
reviewed
Mar 24, 2025
ckandag
reviewed
Mar 24, 2025
The IAM API is eventually consistent. If the user created the wif-config service accounts needed for cluster deployment within too brief a period, then the backend will not yet have access to it. To avoid confusing error messages being returned, the ocm-cli will verify that the backend can see the resources before wif-config creation is considered complete.
Collaborator
Author
|
The attached file shows the user experience creating and updating the wif-config after the included changes. |
ckandag
approved these changes
Mar 25, 2025
ckandag
added a commit
that referenced
this pull request
Apr 4, 2025
-8e28c06 OCM-14358 | unbind service accounts when deleting wif-configs (#723) -62f7db3 Improving UX around gcloud iam api consistency model (#725) -a8ab357 OCM-14357 | Ensuring wif commands are resilient to GCP's consistency model (#726) -c41ad70 Update module github.com/golang-jwt/jwt/v4 to v4.5.2 (#727) -19bb541 Update module github.com/hashicorp/go-version to v1.7.0 (#724) -d4b073f Update Konflux references (#712) -3d30c1c Update module github.com/spf13/pflag to v1.0.6 (#717) -5010823 Update module github.com/openshift-online/ocm-sdk-go to v0.1.463 (#715) -22467d1 various cve updates (#731) -7deabe5 display versions on wif-config describe (#732)
ckandag
added a commit
that referenced
this pull request
Apr 4, 2025
-8e28c06 OCM-14358 | unbind service accounts when deleting wif-configs (#723) -62f7db3 Improving UX around gcloud iam api consistency model (#725) -a8ab357 OCM-14357 | Ensuring wif commands are resilient to GCP's consistency model (#726) -c41ad70 Update module github.com/golang-jwt/jwt/v4 to v4.5.2 (#727) -19bb541 Update module github.com/hashicorp/go-version to v1.7.0 (#724) -d4b073f Update Konflux references (#712) -3d30c1c Update module github.com/spf13/pflag to v1.0.6 (#717) -5010823 Update module github.com/openshift-online/ocm-sdk-go to v0.1.463 (#715) -22467d1 various cve updates (#731) -7deabe5 display versions on wif-config describe (#732)
Merged
rcampos2029
pushed a commit
that referenced
this pull request
Apr 4, 2025
-8e28c06 OCM-14358 | unbind service accounts when deleting wif-configs (#723) -62f7db3 Improving UX around gcloud iam api consistency model (#725) -a8ab357 OCM-14357 | Ensuring wif commands are resilient to GCP's consistency model (#726) -c41ad70 Update module github.com/golang-jwt/jwt/v4 to v4.5.2 (#727) -19bb541 Update module github.com/hashicorp/go-version to v1.7.0 (#724) -d4b073f Update Konflux references (#712) -3d30c1c Update module github.com/spf13/pflag to v1.0.6 (#717) -5010823 Update module github.com/openshift-online/ocm-sdk-go to v0.1.463 (#715) -22467d1 various cve updates (#731) -7deabe5 display versions on wif-config describe (#732)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IAM API is eventually consistent. If the user created the wif-config service accounts needed for cluster deployment within too brief a period, then the backend will not yet have access to it. To avoid confusing error messages being returned, the ocm-cli will verify that the backend can see the resources before wif-config creation is considered complete.
The attached text file shows how the changes included in this patch was tested.
ocm-14483-cli-test.txt