[llmd] Rework the test harness and its surrounding#69
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reached
More reviews will be available in 54 minutes and 47 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (54)
📝 WalkthroughWalkthroughBroad refactor: new DSL/k8s helpers, retry/logging tweaks, and entrypoint migration. Removed legacy llm_d runtime, added RHOAI/KServe/HF cache toolboxes, updated orchestration to runtime_config, and introduced Tekton prepare-only pipeline plus notification controls. ChangesUnified orchestration and tooling refactor
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
|
/test fournos llm_d |
|
🔴 Test of 'fournos_launcher submit' failed after 00 hours 02 minutes 11 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: • Failure indicator: Empty. |
|
/test fournos llm_d |
|
🔴 Test of 'llm_d export-artifacts' failed after 00 hours 00 minutes 00 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: |
|
🔴 Test of 'fournos_launcher submit' failed after 00 hours 01 minutes 30 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: • Failure indicator: Empty. |
|
🔴 Test of 'llm_d export-artifacts' failed after 00 hours 00 minutes 00 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: |
|
/test fournos llm_d |
|
🔴 Test of 'llm_d export-artifacts' failed after 00 hours 00 minutes 00 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: |
|
🔴 Test of 'fournos_launcher submit' failed after 00 hours 01 minutes 31 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: • Failure indicator: Empty. |
|
/test fournos llm_d |
|
🟢 Test of 'fournos_launcher submit' succeeded after 00 hours 01 minutes 52 seconds 🟢 • Link to the test results. • No reports generated... Test configuration: |
|
/test fournos llm_d |
|
🔴 Test of 'llm_d prepare' failed after 00 hours 00 minutes 08 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: |
|
🔴 Test of 'fournos_launcher submit' failed after 00 hours 01 minutes 29 seconds 🔴 • Link to the test results. • No reports generated... Test configuration: • Failure indicator: Empty. |
|
/test fournos llm_d |
|
🟢 Test of 'fournos_launcher submit' succeeded after 00 hours 01 minutes 39 seconds 🟢 • Link to the test results. • No reports generated... Test configuration: |
013b344 to
e72f893
Compare
|
/test fournos llm_d |
|
🟢 Test of 'llm_d test' succeeded after 00 hours 11 minutes 56 seconds 🟢 • Link to the test results. • No reports generated... Test configuration: |
|
🟢 Test of 'fournos_launcher submit' succeeded after 00 hours 13 minutes 19 seconds 🟢 • Link to the test results. • No reports generated... Test configuration: |
|
/test fournos llm_d |
|
🟢 Test of 'llm_d test' succeeded after 00 hours 06 minutes 16 seconds 🟢 • Link to the test results. • No reports generated... Test configuration: |
|
🟢 Test of 'fournos_launcher submit' succeeded after 00 hours 09 minutes 06 seconds 🟢 • Link to the test results. • No reports generated... Test configuration: |
Summary by CodeRabbit
Release Notes
New Features
Improvements