Use OpenSSL from the build environment rather than vendoring it #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ted Poole <tpoole@redhat.com>
tedjpoole
force-pushed
the
alias-openssl
branch
from
31c41d8 to
51935a7
Compare
jwendell
reviewed
Oct 21, 2025
| load("//bazel:repositories.bzl", "define_envoy_implementation") | ||
|
|
||
| # Use OpenSSL from the system rather than vendoring it | ||
| new_local_repository( |
There was a problem hiding this comment.
What about the headers? Do we need to explicitly list them here?
Author
There was a problem hiding this comment.
Sorry, I should have converted this to draft. It's still WIP, and I haven't looked at the headers yet.
Author
|
/retest |
1 similar comment
Author
|
/retest |
|
/override ci/prow/unit ci/prow/unit-arm |
|
@jwendell: Overrode contexts on behalf of jwendell: ci/prow/unit, ci/prow/unit-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
jwendell
approved these changes
Oct 21, 2025
openshift-merge-bot
bot
merged commit 5ec17e3
into
openshift-service-mesh:release-1.27
3 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OpenSSL from the build environment rather than vendoring it.