Skip to content

OCPBUGS-83860: Set DISABLE_IMAGE_POLICY in Konflux Dockerfile#293

Open
bfournie wants to merge 1 commit intoopenshift:mainfrom
bfournie:disable-image-policy
Open

OCPBUGS-83860: Set DISABLE_IMAGE_POLICY in Konflux Dockerfile#293
bfournie wants to merge 1 commit intoopenshift:mainfrom
bfournie:disable-image-policy

Conversation

@bfournie
Copy link
Copy Markdown
Contributor

@bfournie bfournie commented Apr 21, 2026

Set the OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY envirorment variable so that it is passed down to the appliance for building OVE images.

Summary by CodeRabbit

  • Chores
    • Updated ISO builder container image configuration with additional environment variable settings.

Set the OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY envirorment
variable so that it is passed down to the appliance for building
OVE images.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-83860, which is invalid:

  • expected the bug to target either version "5.0." or "openshift-5.0.", but it targets "4.23.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Set the OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY envirorment variable so that it is passed down to the appliance for building OVE images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ae95aa91-da92-45c0-9db1-a9ba7ee303f6

📥 Commits

Reviewing files that changed from the base of the PR and between 210b295 and 4a4468d.

📒 Files selected for processing (1)
  • tools/iso_builder/Dockerfile

Walkthrough

An environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY=true was added to the build stage of the ISO builder Dockerfile. This sets the variable in the resulting container image without modifying any other container configuration, commands, or build logic.

Changes

Cohort / File(s) Summary
Dockerfile Configuration
tools/iso_builder/Dockerfile
Added environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY=true to the build stage container image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: setting the DISABLE_IMAGE_POLICY environment variable in the Konflux Dockerfile, which matches the actual modification in tools/iso_builder/Dockerfile.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only modifies a Dockerfile to set an environment variable and does not touch any test files or Ginkgo test definitions.
Test Structure And Quality ✅ Passed The PR only modifies a Dockerfile to add an environment variable. The custom check for Test Structure and Quality reviews Ginkgo test code. No test code was modified, so the check does not apply.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests were added in this PR. The custom check applies only when new test files are modified, which did not occur here.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests, only modifies a Dockerfile, so the SNO test compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The change only adds an environment variable to a Dockerfile used for building an installation ISO, not for deploying Kubernetes resources. No deployment manifests, operator code, controllers, or scheduling constraints are introduced or modified.
Ote Binary Stdout Contract ✅ Passed Repository builds agent installation tools, not OTE test binaries. PR only modifies Dockerfile environment variable. No OTE dependencies present.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. It only modifies tools/iso_builder/Dockerfile to set an environment variable.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bfournie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2026
@bfournie
Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 21, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@bfournie: This pull request references Jira Issue OCPBUGS-83860, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 21, 2026

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 4a4468d link true /test unit
ci/prow/e2e-agent-bad-dns 4a4468d link true /test e2e-agent-bad-dns
ci/prow/govet 4a4468d link true /test govet
ci/prow/e2e-agent-compact-ipv4 4a4468d link true /test e2e-agent-compact-ipv4
ci/prow/okd-scos-images 4a4468d link true /test okd-scos-images
ci/prow/gofmt 4a4468d link true /test gofmt
ci/prow/images 4a4468d link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants