-
Notifications
You must be signed in to change notification settings - Fork 12
OAPE-36: Updates ansible-collections and downstream e2e test to match upstream v1.36.1 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
254ac8a
to
d029676
Compare
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @arkadeepsen |
The updated e2e test is working fine: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_ansible-operator-plugins/35/pull-ci-openshift-ansible-operator-plugins-main-e2e-ansible/1885387903203282944 /lgtm /cc @TrilokGeer |
FROM openshift-ansible-operator-plugins | ||
|
||
COPY openshift/ci/testdata/ansible/memcached-operator/requirements.yml ${HOME}/requirements.yml | ||
COPY testdata/memcached-molecule-operator/requirements.yml ${HOME}/requirements.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any path change in CI ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to change the CI job setup in https://github.com/openshift/release, because the make targets and Dockerfile paths remain unchanged.
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
d029676
to
a327250
Compare
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a327250
to
009d0f6
Compare
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
009d0f6
to
9c43f16
Compare
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…l` file to match the upstream requirements for ansible-collection as per v1.36.1 Signed-off-by: chiragkyal <ckyal@redhat.com>
…ions` directory by running `openshift/release/ansible/update-collections.sh` script to align with the updated requirements.yml Signed-off-by: chiragkyal <ckyal@redhat.com>
…eck-collections` for ansible-collections modification Signed-off-by: chiragkyal <ckyal@redhat.com>
…ata/memcached-molecule-operator` - Adds RBAC permission for `project.openshift.io`. - Adds `--ignore-not-found` with `make undeploy` to avoid errors when some kustomized resources are deleted with namespace deletion. Signed-off-by: chiragkyal <ckyal@redhat.com>
…a/ansible/memcached-operator` directory because of the utilization of upstream testdata. Signed-off-by: chiragkyal <ckyal@redhat.com>
9c43f16
to
cdfba54
Compare
@chiragkyal: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chiragkyal, TrilokGeer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
@chiragkyal: This pull request references OAPE-36 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherrypick release-4.18 |
@chiragkyal: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked. Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-ansible-operator |
Description of the change:
openshift/release/ansible/requirements.yml
file to match the upstream requirements for ansible-collection as per v1.36.1.openshift/release/ansible/ansible_collections
directory by runningsh openshift/release/ansible/update-collections.sh
script to align with the updatedrequirements.yml
.update-collections
andcheck-collections
for ansible-collections modification.testdata/memcached-molecule-operator
.project.openshift.io
--ignore-not-found
withmake undeploy
to avoid errors when some kustomized resources are deleted with namespace deletion.openshift/ci/testdata/ansible/memcached-operator
directory because of the utilization of upstream testdata.Motivation for the change:
https://issues.redhat.com//browse/OAPE-36