Allow ports on host to be specified for HostNetwork Ingresses #1097
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -536,6 +536,46 @@ type HostNetworkStrategy struct { | |
| // +kubebuilder:validation:Optional | ||
| // +optional | ||
| Protocol IngressControllerProtocol `json:"protocol,omitempty"` | ||
|
|
||
| // httpPort is the port on the host which should be used to listen for | ||
| // HTTP requests. This field should be set when port 80 is already in use. | ||
| // The value should not coincide with the NodePort range of the cluster. | ||
| // When not specified the value defaults to 80. | ||
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:validation:Maximum=65535 | ||
| // +kubebuilder:validation:Minimum=1 | ||
| // +kubebuilder:default=80 | ||
| HTTPPort int32 `json:"httpPort"` | ||
|
Contributor
There was a problem hiding this comment. CRD changes can be observed on a delay. What does the operator do when this field is zero-value, not 80, because the kube-apiserver has not observed the default.
Contributor
Author
There was a problem hiding this comment. We will have the same defaults also in the operator so if a 0 is observed it is defaulted there as well. https://github.com/openshift/cluster-ingress-operator/pull/694/files#L392-L404 |
||
|
|
||
| // httpsPort is the port on the host which should be used to listen for | ||
| // HTTPS requests. This field should be set when port 443 is already in use. | ||
| // The value should not coincide with the NodePort range of the cluster. | ||
| // When not specified the value defaults to 443. | ||
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:validation:Maximum=65535 | ||
| // +kubebuilder:validation:Minimum=1 | ||
| // +kubebuilder:default=443 | ||
| HTTPSPort int32 `json:"httpsPort"` | ||
|
|
||
| // statsPort is the port on the host where the stats from the router are | ||
| // published. The value should not coincide with the NodePort range of the | ||
| // cluster. If an external load balancer is configured to forward connections | ||
| // to this IngressController, the load balancer should use this port for | ||
| // health checks. The load balancer can send HTTP probes on this port on a | ||
| // given node, with the path /healthz/ready to determine if the ingress | ||
| // controller is ready to receive traffic on the node. For proper operation | ||
| // the load balancer must not forward traffic to a node until the health | ||
| // check reports ready. The load balancer should also stop forwarding requests | ||
| // within a maximum of 45 seconds after /healthz/ready starts reporting | ||
| // not-ready. Probing every 5 to 10 seconds, with a 5-second timeout and with | ||
| // a threshold of two successful or failed requests to become healthy or | ||
| // unhealthy respectively, are well-tested values. When not specified the | ||
| // value defaults to 1936. | ||
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:validation:Maximum=65535 | ||
|
Contributor
There was a problem hiding this comment. do we know where the nodeport range starts in openshift clusters?
Contributor
Author
There was a problem hiding this comment. It appears to be configurable. The default is 30000-32767 but a user could configure it to start at a lower port number than 30000. Also the user might want to use a port outside the nodeport range, both higher or lower. |
||
| // +kubebuilder:validation:Minimum=1 | ||
| // +kubebuilder:default=1936 | ||
| StatsPort int32 `json:"statsPort"` | ||
| } | ||
|
|
||
| // PrivateStrategy holds parameters for the Private endpoint publishing | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each new field, please add a sentence describing the default value. The default value that is specified by the kubebuilder tag doesn't show in generated Swagger or the OpenAPI schema.