Skip to content

Conversation

exdx
Copy link

@exdx exdx commented Jul 18, 2022

Adds a new feature flag for the Platform Operators Openshift-only feature.

Signed-off-by: Daniel Sover dsover@redhat.com

Signed-off-by: Daniel Sover <dsover@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

Hello @exdx! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@openshift-ci openshift-ci bot requested review from deads2k and jwforres July 18, 2022 19:35
@timflannagan
Copy link
Contributor

Link to the EP that proposes introducing this feature flag: openshift/enhancements#1170. Note: that EP still hasn't been approved yet.

cc @bparees @joelanford

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 18, 2022

@exdx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@michaelryanpeter
Copy link

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 18, 2022
@jianzhangbjz
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 20, 2022
@tylerslaton
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: exdx, tylerslaton
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval by writing /assign @derekwaynecarr in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@exdx
Copy link
Author

exdx commented Jul 22, 2022

/hold

It's unclear whether this is actually required for PO Phase 0, and what the response from PX will be.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@joelanford
Copy link
Member

^ +1 to the hold.

Since the entire PO system will be tech preview for phase 0, I think we're planning to use CVO's release.openshift.io/feature-gate: "TechPreviewNoUpgrade" annotation support in the PO manifests.

@exdx
Copy link
Author

exdx commented Aug 1, 2022

Closing as this is not required for PO Phase 0.

@exdx exdx closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants