Skip to content

Conversation

haircommander
Copy link
Member

While it technically doesn't do anything (As the crun feature is toggled by TechPreviewNoUpgrade),
it does make users aware of the feature they're enabling with TechPreviewNoUpgrade

Signed-off-by: Peter Hunt~ pehunt@redhat.com

While it technically doesn't do anything (As the crun feature is toggled by TechPreviewNoUpgrade),
it does make users aware of the feature they're enabling with TechPreviewNoUpgrade

Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2022

Hello @haircommander! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@haircommander
Copy link
Member Author

cc @harche @rphillips @mrunalp

/assign @deads2k

@haircommander
Copy link
Member Author

this is a cosmetic change for https://issues.redhat.com/browse/OCPNODE-1141

@deads2k
Copy link
Contributor

deads2k commented Aug 25, 2022

/approve
/assign @rphillips

leaving lgtm with @rphillips

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, haircommander, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rphillips
Copy link
Contributor

/label qe-approved
/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Aug 26, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 2 against base HEAD bad89a2 and 8 for PR HEAD f12049b in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 26, 2022

@haircommander: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b21e86c into openshift:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants