-
Notifications
You must be signed in to change notification settings - Fork 574
TechPreviewNoUpgrade: add Crun feature to set #1268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While it technically doesn't do anything (As the crun feature is toggled by TechPreviewNoUpgrade), it does make users aware of the feature they're enabling with TechPreviewNoUpgrade Signed-off-by: Peter Hunt~ <pehunt@redhat.com>
Hello @haircommander! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
cc @harche @rphillips @mrunalp /assign @deads2k |
this is a cosmetic change for https://issues.redhat.com/browse/OCPNODE-1141 |
/approve leaving lgtm with @rphillips |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, haircommander, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
@haircommander: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
While it technically doesn't do anything (As the crun feature is toggled by TechPreviewNoUpgrade),
it does make users aware of the feature they're enabling with TechPreviewNoUpgrade
Signed-off-by: Peter Hunt~ pehunt@redhat.com