NE-799: config/ingress: "loadbalancer" → "loadBalancer"

[Miciah]

Change the json tag for the recently added LoadBalancer field from "loadbalancer" to "loadBalancer" for consistency with other APIs.

Follow-up to #1209.

• config/v1/types_ingress.go (IngressSpec): Change "loadbalancer" to "loadBalancer".
• config/v1/0000_10_config-operator_01_ingress.crd.yaml:
• config/v1/zz_generated.swagger_doc_generated.go:
• openapi/generated_openapi/zz_generated.openapi.go:
• openapi/openapi.json: Regenerate.

[openshift-ci]

Hello @Miciah! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

• For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
• For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
• For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

[Miciah]

/test integration

[miheer]

Hi @Miciah! I tested this with the installer but the units test fail.

git clone installer code
cd installer
git rebase origin/master

GO111MODULE=on GOFLAGS=-mod=vendor go mod edit -replace=github.com/openshift/api=github.com/Miciah/api@24ee13c

go mod tidy
go mod vendor

Unit test

[miheer@localhost installer]$ GO111MODULE=on go test -v -run Test  ./pkg/asset/manifests/...
# k8s.io/client-go/tools/record
vendor/k8s.io/client-go/tools/record/event.go:301:13: assignment mismatch: 1 variable but e.Watch returns 2 values
vendor/k8s.io/client-go/tools/record/event.go:349:13: assignment mismatch: 1 variable but recorder.ActionOrDrop returns 2 values
FAIL	github.com/openshift/installer/pkg/asset/manifests [build failed]
?   	github.com/openshift/installer/pkg/asset/manifests/alibabacloud	[no test files]
=== RUN   TestCloudProviderConfig
--- PASS: TestCloudProviderConfig (0.00s)
PASS
ok  	github.com/openshift/installer/pkg/asset/manifests/azure	(cached)
=== RUN   TestCloudProviderConfig
--- PASS: TestCloudProviderConfig (0.00s)
=== RUN   TestCloudProviderConfigWithNPID
--- PASS: TestCloudProviderConfigWithNPID (0.00s)
PASS
ok  	github.com/openshift/installer/pkg/asset/manifests/gcp	(cached)
=== RUN   TestCloudProviderConfig
=== RUN   TestCloudProviderConfig/default_subnet_config
=== RUN   TestCloudProviderConfig/existing_subnet_config
--- PASS: TestCloudProviderConfig (0.00s)
    --- PASS: TestCloudProviderConfig/default_subnet_config (0.00s)
    --- PASS: TestCloudProviderConfig/existing_subnet_config (0.00s)
PASS
ok  	github.com/openshift/installer/pkg/asset/manifests/ibmcloud	(cached)
FAIL	github.com/openshift/installer/pkg/asset/manifests/openstack [build failed]
?   	github.com/openshift/installer/pkg/asset/manifests/powervs	[no test files]
=== RUN   TestCloudProviderConfig
=== RUN   TestCloudProviderConfig/valid_in-tree_cloud_provider_config
=== RUN   TestCloudProviderConfig/valid_out_of_tree_cloud_provider_config
[Global]
secret-name = "vsphere-creds"
secret-namespace = "kube-system"
insecure-flag = "1"

[VirtualCenter "test-vcenter"]
port = "443"

datacenters = "test-datacenter,test-datacenter2"

[Workspace]
folder = "/test-datacenter/vm/clusterID"

[Labels]
region = "openshift-region"
zone = "openshift-zone"

--- PASS: TestCloudProviderConfig (0.00s)
    --- PASS: TestCloudProviderConfig/valid_in-tree_cloud_provider_config (0.00s)
    --- PASS: TestCloudProviderConfig/valid_out_of_tree_cloud_provider_config (0.00s)
PASS
ok  	github.com/openshift/installer/pkg/asset/manifests/vsphere	(cached)
FAIL
[miheer@localhost installer]$

[deads2k]

/approve
/hold

holding so @Miciah can chase usage and be sure the change will work.

[lihongan]

/label qe-approved

[CFields651]

/label px-approved

[Miciah]

/hold cancel

[ahardin-rh]

/label docs-approved

[miheer]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, Miciah, miheer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.