-
Notifications
You must be signed in to change notification settings - Fork 581
STOR-1133: set RetroactiveDefaultStorageClass feature as TechPreview #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1133: set RetroactiveDefaultStorageClass feature as TechPreview #1386
Conversation
When debugging feature gate tests run with `make test-unit` it is not clear what the test expects. Adding a better log message to show all relevant values making it easier to debug.
The feature is currently beta upstream so it is enabled by default. Since there is no guarantee the feature won't be changed or removed it is safer to release this feature as TechPreview so admins will have to opt-in with TechPreviewNoUpgrade feature set in OpenShift.
|
Hello @RomanBednar! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
|
lgtm from storage POV, we want a Beta feature turned off by default, because it changes behavior of StorageClasses and there is no other API that would enable the new behavior while the feature is still beta / tech preview. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, jsafrane, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@RomanBednar: No Jira bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Doc and QE trackers are approved: https://issues.redhat.com/browse/STOR-1103 /label docs-approved Also this can not be tested before merge, adding px label. /label px-approved |
|
@RomanBednar: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We want to release RetroactiveDefaultStorageClass as TechPreview in 4.13: https://issues.redhat.com/browse/STOR-1133
KEP: kubernetes/enhancements#3333
cc @openshift/storage