Skip to content

Retract v3.9.0+incompatible #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2023
Merged

Retract v3.9.0+incompatible #1515

merged 1 commit into from
Jul 5, 2023

Conversation

@dmage
Copy link
Contributor

@dmage dmage commented Jul 4, 2023

Similar to openshift/client-go#246, this change retracts the only published version v3.9.0+incompatible.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

Hello @dmage! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2023
@openshift-ci openshift-ci bot requested review from bparees and sjenning July 4, 2023 15:35
@dmage
Copy link
Contributor Author

dmage commented Jul 4, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 4, 2023

@dmage: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 391aead into openshift:master Jul 5, 2023
mauri870 added a commit to mauri870/elastic-agent that referenced this pull request Jul 12, 2024
@mauri870
Require a valid version of github.com/openshift/api
11c1c7d 
If you run go mod tidy it fails with:

	go: downloading github.com/openshift/api v3.9.0+incompatible
	unknown revision v3.9.0

The go.sum points to github.com/openshift/api@v3.9.0 but this version does
not exist, it was retracted in openshift/api#1515

Added a replace directive to pin the library to a known commit that points
to the now retracted v3.9.0 release.
@mauri870 mauri870 mentioned this pull request Jul 12, 2024
Merged
mauri870 added a commit to mauri870/elastic-agent that referenced this pull request Jul 13, 2024
@mauri870
Require a valid version of github.com/openshift/api
ef633a0 
If you run go mod tidy it fails with:

	go: downloading github.com/openshift/api v3.9.0+incompatible
	unknown revision v3.9.0

The go.sum points to github.com/openshift/api@v3.9.0 but this version does
not exist, it was retracted in openshift/api#1515

Added a replace directive to pin the library to a known commit that points
to the now retracted v3.9.0 release.
cmacknz pushed a commit to elastic/elastic-agent that referenced this pull request Jul 24, 2024
@mauri870
Require a valid version of github.com/openshift/api (#5132)
907cfa7 
* Require a valid version of github.com/openshift/api

If you run go mod tidy it fails with:

	go: downloading github.com/openshift/api v3.9.0+incompatible
	unknown revision v3.9.0

The go.sum points to github.com/openshift/api@v3.9.0 but this version does
not exist, it was retracted in openshift/api#1515

Added a replace directive to pin the library to a known commit that points
to the now retracted v3.9.0 release.

* add comment to replace directive

* make notice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@sjenning sjenning Awaiting requested review from sjenning

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dmage @soltysh @openshift-merge-robot