Skip to content

API-1710: Add configuration option to specify the type of service account token to use #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

API-1710: Add configuration option to specify the type of service account token to use #1758

wants to merge 2 commits into from

Conversation

@sanchezl
Copy link
Contributor

@sanchezl sanchezl commented Feb 7, 2024 •
edited
Loading

Introduce a configuration option to allow users to specify the type of service account token to use for the integrated image registry image pull secret auth.

apiVersion: operator.openshift.io/v1
kind: OpenShiftControllerManager
spec:
  imageRegistryAuthTokenType: Legacy

In version v4.15:

  • The default, and only value, will be Legacy.
  • The value will explicitly be added to the OCM-O config.

In version 4.16:

  • The default value will be Bound.
  • The value will not be explicitly set.
  • Users who upgrade from v4.15 will still be configured to use the Legacy service account tokens until they update the OCM-O config to switch to Bound.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

Hello @sanchezl! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sanchezl
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2024
@sanchezl sanchezl changed the title master add config for image registry auth service account token type Feb 8, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 8, 2024
@sanchezl sanchezl marked this pull request as ready for review February 8, 2024 15:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and mfojtik February 8, 2024 15:46
@sanchezl sanchezl changed the title add config for image registry auth service account token type Proof: add config for image registry auth service account token type Feb 8, 2024
@sanchezl sanchezl changed the title Proof: add config for image registry auth service account token type add config for image registry auth service account token type Feb 8, 2024
@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 8, 2024

/retest

@sanchezl sanchezl mentioned this pull request Feb 8, 2024
Closed
@sanchezl sanchezl changed the title add config for image registry auth service account token type API-1710: Add configuration option to specify the type of service account token to use Feb 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 8, 2024 •
edited by openshift-ci bot
Loading

@sanchezl: This pull request references API-1710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Introduce a configuration option to allow users to specify the type of service account token to use for the integrated image registry image pull secret auth.

apiVersion: operator.openshift.io/v1
kind: OpenShiftControllerManager
spec:
 imageRegistryAuthTokenType: Legacy

In version v4.15:

  • The default, and only value, will be Legacy.
  • The value will explicitly be added to the OCM-O config.

In version 4.16:

  • The default value will be Bound.
  • The value will not be explicitly set.
  • Users who upgrade from v4.15 will still be configured to use the Legacy service account tokens until they update the OCM-O config to switch to Bound.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 9, 2024 •
edited
Loading 

workflow-upgrade openshift-upgrade-aws openshift/cluster-openshift-controller-manager-operator#331 openshift/cluster-openshift-controller-manager-operator#332

job

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2024 •
edited by openshift-ci bot
Loading

@sanchezl: This pull request references API-1710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Introduce a configuration option to allow users to specify the type of service account token to use for the integrated image registry image pull secret auth.

apiVersion: operator.openshift.io/v1
kind: OpenShiftControllerManager
spec:
 imageRegistryAuthTokenType: Legacy

In version v4.15:

  • The default, and only value, will be Legacy.
  • The value will explicitly be added to the OCM-O config.

In version 4.16:

  • The default value will be Bound.
  • The value will not be explicitly set.
  • Users who upgrade from v4.15 will still be configured to use the Legacy service account tokens until they update the OCM-O config to switch to Bound.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2024 •
edited by openshift-ci bot
Loading

@sanchezl: This pull request references API-1710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Introduce a configuration option to allow users to specify the type of service account token to use for the integrated image registry image pull secret auth.

apiVersion: operator.openshift.io/v1
kind: OpenShiftControllerManager
spec:
 imageRegistryAuthTokenType: Legacy

In version v4.15:

  • The default, and only value, will be Legacy.
  • The value will explicitly be added to the OCM-O config.

In version 4.16:

  • The default value will be Bound.
  • The value will not be explicitly set.
  • Users who upgrade from v4.15 will still be configured to use the Legacy service account tokens until they update the OCM-O config to switch to Bound.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 9, 2024 •
edited by openshift-ci bot
Loading

@sanchezl: This pull request references API-1710 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.16.0" version, but no target version was set.

In response to this:

Introduce a configuration option to allow users to specify the type of service account token to use for the integrated image registry image pull secret auth.

apiVersion: operator.openshift.io/v1
kind: OpenShiftControllerManager
spec:
 imageRegistryAuthTokenType: Legacy

In version v4.15:

  • The default, and only value, will be Legacy.
  • The value will explicitly be added to the OCM-O config.

In version 4.16:

  • The default value will be Bound.
  • The value will not be explicitly set.
  • Users who upgrade from v4.15 will still be configured to use the Legacy service account tokens until they update the OCM-O config to switch to Bound.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sanchezl
Copy link
Contributor Author

sanchezl commented Feb 11, 2024

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 11, 2024

@sanchezl: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sanchezl sanchezl closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanchezl @openshift-ci-robot